Feature implementation Rotation along path and path context with toPoints and toKeyPoints #566
Conversation
|
@microsoft-github-policy-service agree |
|
Thanks for the contribution! Can I ask that you:
In this case, let's only make changes to |
Reverted other changes. |
|
can we resolve the comments or changes needed? |
noobd3v
changed the title
|
Hi @danmarshall I have made changes as per the comments please check and let me know if all looks good and we can merge and close the pr. |
| (chainPoints)=> { | ||
| for(let i = 0; i < chainPoints.length; i++) | ||
| { | ||
| alongPathAngles.push(angle.ofPointInDegrees(chainPoints[i].link.endPoints[0], chainPoints[i].link.endPoints[1])); |
There was a problem hiding this comment.
Here is where we need to look at the angle at ratio r (if it is an arc)
|
Hi @noobd3v , thanks for the contribution and your patience. As we go through this implementation, we are uncovering many ideas that we need to think through carefully. Also, I think we will need to add a couple of small unit tests which exercise the new feature. |
Rotation along the path of layout