Add free bsd firewall #2606
Open
Add free bsd firewall #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharsonia
force-pushed
the
AddFreeBSDFirewall
branch
2 times, most recently
from
4eb1efc
to
f38ac53
Compare
LiliDeng
reviewed
Feb 16, 2023
LiliDeng
reviewed
Feb 16, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
sharsonia
force-pushed
the
AddFreeBSDFirewall
branch
3 times, most recently
from
2939e53
to
4f5b62c
Compare
|
@somil55 can you verify it? |
dsrivastavv
reviewed
May 17, 2023
|
|
||
|
|
||
| class Ipf(Tool): | ||
| _ipf_enable_pattern = re.compile( |
There was a problem hiding this comment.
Can you please add few example patterns here?
|
@sharsonia, can @somil55 continue on this PR? |
@squirrelsc - Will update this today and test it out |
sharsonia
force-pushed
the
AddFreeBSDFirewall
branch
from
94076eb
to
93d787a
Compare
sharsonia
force-pushed
the
AddFreeBSDFirewall
branch
9 times, most recently
from
391defa
to
d34481a
Compare
sharsonia
force-pushed
the
AddFreeBSDFirewall
branch
from
d34481a
to
ee672e7
Compare
dsrivastavv
reviewed
Jul 24, 2023
| force_run=True, | ||
| ) | ||
| ipf_enable_found = re.search(self._ipf_enable_pattern, cmd_result) | ||
| if ipf_enable_found: |
There was a problem hiding this comment.
Do we need to reload the service using this file rc.conf file?
There was a problem hiding this comment.
Do we need to reload the service using this file rc.conf file?
Hmm think we can do "service ipfilter start" to start IPF.
sharsonia
force-pushed
the
AddFreeBSDFirewall
branch
4 times, most recently
from
255e72c
to
51d9acc
Compare
|
@sharsonia @somil55 any update on this PR? If it's useful, can we merge it with a priority? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.