-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BumpDeps: mypy #2545
base: main
Are you sure you want to change the base?
BumpDeps: mypy #2545
Conversation
Brought in the typing changes from the unpinning PR. This should be ready to go. |
@LiliDeng When you have time, please let Avram know which scenarios should be covered. For the marketplace image, SIG loading tests, it may need to run multiple test cases together, which will load image object from memory. |
fa09b81
to
2d11181
Compare
2cbde7e
to
6efe1d7
Compare
6af232c
to
0238a7d
Compare
0238a7d
to
1019849
Compare
1019849
to
de8c44f
Compare
de8c44f
to
5d6686b
Compare
5d6686b
to
d2befb6
Compare
@squirrelsc Rebased again. This basic maintenance PR is now 3 months old. and we're running a version of Mypy that was superseded a year ago. |
It contains many changes, we don't have bandwidth to test regressions. Please disable related rules, and focus on upgrading mypy version in this PR. |
That's what I am doing. These are just the changes to make it pass. It keeps growing because it hasn't been merged in so long and bad code keep getting implemented. This is why you have to keep up with dependencies. |
Please split changes into separated PRs, and provide tested scenarios. We can evaluate the test coverage and remaining risks. |
What is there to split? These are the changes need to work with the new version. This is a relatively simple PR for anyone with intermediate Python skills to review. |
Created by Github Action