Dumb but fast writer #120
Merged
Dumb but fast writer #120
+50
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same performance as "Bool writer like reader #118"
|
Similar perf here. The inner loop is slightly faster (avoid the lzcnt which is seems slow) but for some reason it doesn't translate to overall better perf. I'll use this one preferring simpler code. |
mcroomp
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same performance as "Bool writer like reader #118"
@mcroomp if you could test both branches on different hardware we can choose what to merge into
main. On mine 5950x they are both of the same performance.