Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 5442/add automated tests to vscode extension #5540

Merged
merged 6 commits into from
Nov 11, 2024
Merged

Task 5442/add automated tests to vscode extension #5540

merged 6 commits into from
Nov 11, 2024

Conversation

fey101
Copy link
Contributor

@fey101 fey101 commented Oct 7, 2024

Step 1 of #5442

@fey101 fey101 force-pushed the task-5442/Add-automated-tests-to-vscode-extension branch from d6bd12b to b7f9f07 Compare October 7, 2024 10:04
@thewahome
Copy link
Contributor

question Is the plan to also have a test step in the yaml file so that the testing experience is available on CI/CD too?

@fey101 fey101 force-pushed the task-5442/Add-automated-tests-to-vscode-extension branch 3 times, most recently from 6812c03 to b4bd888 Compare October 11, 2024 07:26
@fey101 fey101 force-pushed the task-5442/Add-automated-tests-to-vscode-extension branch 19 times, most recently from 6dc4e92 to 148dd2a Compare October 22, 2024 10:47
baywet
baywet requested changes Oct 22, 2024
View reviewed changes
.github/workflows/build-vscode-extension.yml Show resolved Hide resolved
vscode/microsoft-kiota/package.json Outdated Show resolved Hide resolved
@fey101 fey101 force-pushed the task-5442/Add-automated-tests-to-vscode-extension branch 2 times, most recently from 35e7fb7 to bfb57ea Compare October 23, 2024 10:07
@fey101 fey101 marked this pull request as ready for review October 23, 2024 10:10
@fey101 fey101 requested a review from a team as a code owner October 23, 2024 10:10
@baywet baywet marked this pull request as draft October 23, 2024 11:48
@fey101 fey101 enabled auto-merge (squash) October 28, 2024 06:07
@thewahome
Copy link
Contributor

When the tests run, this error is attached to the command tests file. Is there a way to remove it?

Error: Please provide instrumentation key
	at throwError (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:1768:11)
	at /home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:7414:[92](https://github.com/microsoft/kiota/actions/runs/11520315724/job/32071340516#step:9:93)
	at Object._useHandler [as use] (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:6597:13)
	at _createAndUseHandler (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:5691:11)
	at Object._watch [as watch] (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:5724:16)
	at _self.<computed> [as initialize] (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:73[96](https://github.com/microsoft/kiota/actions/runs/11520315724/job/32071340516#step:9:97):125)
	at AppInsightsCore.dynProtoProxy [as initialize] (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:1107:29)
	at _initialize (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:19848:22)
	at /home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:1[97](https://github.com/microsoft/kiota/actions/runs/11520315724/job/32071340516#step:9:98)90:13
	at dynamicProto (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:1265:5)
	at new ApplicationInsights (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:19785:79)
	at appInsightsClientFactory (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:16529:29)

@fey101
Copy link
Contributor Author

fey101 commented Oct 28, 2024

When the tests run, this error is attached to the command tests file. Is there a way to remove it?

Error: Please provide instrumentation key
	at throwError (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:1768:11)
	at /home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:7414:[92](https://github.com/microsoft/kiota/actions/runs/11520315724/job/32071340516#step:9:93)
	at Object._useHandler [as use] (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:6597:13)
	at _createAndUseHandler (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:5691:11)
	at Object._watch [as watch] (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:5724:16)
	at _self.<computed> [as initialize] (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:73[96](https://github.com/microsoft/kiota/actions/runs/11520315724/job/32071340516#step:9:97):125)
	at AppInsightsCore.dynProtoProxy [as initialize] (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:1107:29)
	at _initialize (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:19848:22)
	at /home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:1[97](https://github.com/microsoft/kiota/actions/runs/11520315724/job/32071340516#step:9:98)90:13
	at dynamicProto (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:1265:5)
	at new ApplicationInsights (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:19785:79)
	at appInsightsClientFactory (/home/runner/work/kiota/kiota/vscode/microsoft-kiota/dist/extension.js:16529:29)

This is not related to the tests. It's always been there so it's really out of scope for the tests. We can create a ticket to look into fixing it though.

@fey101 fey101 force-pushed the task-5442/Add-automated-tests-to-vscode-extension branch from e53d084 to 8a2611e Compare October 28, 2024 10:04
@fey101 fey101 force-pushed the task-5442/Add-automated-tests-to-vscode-extension branch 7 times, most recently from c0ca9f8 to b3c0825 Compare November 4, 2024 09:18
thewahome
thewahome previously approved these changes Nov 5, 2024
View reviewed changes
koros
koros previously approved these changes Nov 5, 2024
View reviewed changes
@fey101
Setup unittests
8ee96f0 
wip
@fey101
initial coverage setup
cd1a8f2 
Improve coverage configs

checkpoint 1

checkpoint 2

checkpoint 3

add task to run test in build-extension workflow

Add sonar cloud analysis step

Remove unused libraries

Add projectKey to sonar properties
@fey101
test monorepo setup
2bfe0d3
@fey101
use paths for pull_request trigger
852deff
@fey101
Remove unuseful asyc function wrap in check is online
f364acc
@fey101
leaveOut moduleresolution and skipLibCheck option in config
3535b93
@fey101 fey101 dismissed stale reviews from koros and thewahome via 3535b93 November 11, 2024 16:18
@fey101 fey101 force-pushed the task-5442/Add-automated-tests-to-vscode-extension branch from b3c0825 to 3535b93 Compare November 11, 2024 16:18
@fey101 fey101 mentioned this pull request Nov 11, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Failed Quality Gate failed for 'microsoft_kiota_frontend'

Failed conditions
30.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@fey101 fey101 merged commit e843dce into main Nov 11, 2024
210 of 211 checks passed
@fey101 fey101 deleted the task-5442/Add-automated-tests-to-vscode-extension branch November 11, 2024 16:32
@baywet baywet mentioned this pull request Nov 11, 2024
Closed
@thewahome thewahome linked an issue Nov 21, 2024 that may be closed by this pull request
Add automated tests to the VSCode extension #5442
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@thewahome thewahome thewahome left review comments

@koros koros koros left review comments

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add automated tests to the VSCode extension
4 participants
@fey101 @thewahome @baywet @koros