-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Show as Binary #429
base: main
Are you sure you want to change the base?
Conversation
@Deprecated | ||
public boolean hex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hex
is part of the specification: https://microsoft.github.io/debug-adapter-protocol/specification#Types_ValueFormat, what's the rationale for deprecating this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of new functionality we can format values to different formats now, beside hex. And I added new property ValueFormat#type
instead of ValueFormat#hex
to support that possibility. I assumed we can delete ValueFormat#hex
in future with no harm because of no need and marked hex
as deprecated. Just tell me if I did something wrong and I'll fix it. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed @Deprecated
annotation and added doc to new property ValueFormat#type
. Support of the old valueFormat.hex
already was in my code for backward compatibility.
Should I create PR to DAP or do something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When contributing to the DAP, you need to open an issue to discuss the proposal first. Only if the proposal is accepted, then open a PR.
A quick search and found a duplicated issue for more formatting options. microsoft/debug-adapter-protocol#197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! If there is no other issue could you approve this PR?)
Hi there!
This is PR for allow represent variables in binary forma.
I think it may be helpful for vscode-java-debug issue #1078
I've added new protocol parameter 'formatType' should contains variable format such as [BIN, OCT, HEX, DEC].
I've remain "showHex" for backward compatibility and can be delete later when PR to vscode-java-debug will be merged.
If you are not interested in this changes fill free to close this PR :)