refactor(application): wrap execution with try blocks, ensure proper …

[Richard-Jang]

…exit codes (#289)

Pull Request

Description

• Add Main Execution region
• wrap main execution block in a try catch
• added exit with proper code where missing

Related Issue(s)

Fixes #289

Type of Change

Select all that apply:

Code & Documentation:

• Bug fix (non-breaking change fixing an issue)
• New feature (non-breaking change adding functionality)
• Breaking change (fix or feature causing existing functionality to change)
• Documentation update

Infrastructure & Configuration:

• GitHub Actions workflow
• Linting configuration (markdown, PowerShell, etc.)
• Security configuration
• DevContainer configuration
• Dependency update

AI Artifacts:

• Reviewed contribution with prompt-builder agent and addressed all feedback
• Copilot instructions (.github/instructions/*.instructions.md)
• Copilot prompt (.github/prompts/*.prompt.md)
• Copilot agent (.github/agents/*.agent.md)

Note for AI Artifact Contributors:

• Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.
• Model Versions: Only contributions targeting the latest Anthropic and OpenAI models will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
• See Agents Not Accepted and Model Version Requirements.

Other:

• Script/automation (.ps1, .sh, .py)
• Other (please describe): refactor code

Sample Prompts (for AI Artifact Contributions)

User Request:

Execution Flow:

Output Artifacts:

Success Indicators:

For detailed contribution requirements, see:

• Common Standards: docs/contributing/ai-artifacts-common.md - Shared standards for XML blocks, markdown quality, RFC 2119, validation, and testing
• Agents: docs/contributing/custom-agents.md - Agent configurations with tools and behavior patterns
• Prompts: docs/contributing/prompts.md - Workflow-specific guidance with template variables
• Instructions: docs/contributing/instructions.md - Technology-specific standards with glob patterns

Testing

Checklist

Required Checks

• Documentation is updated (if applicable)
• Files follow existing naming conventions
• Changes are backwards compatible (if applicable)
• Tests added for new functionality (if applicable)

AI Artifact Contributions

• Used /prompt-analyze to review contribution
• Addressed all feedback from prompt-builder review
• Verified contribution follows common standards and type-specific requirements

Required Automated Checks

The following validation commands must pass before merging:

• Markdown linting: npm run lint:md
• Spell checking: npm run spell-check
• Frontmatter validation: npm run lint:frontmatter
• Link validation: npm run lint:md-links
• PowerShell analysis: npm run lint:ps

Security Considerations

• This PR does not contain any sensitive or NDA information
• Any new dependencies have been reviewed for security issues
• Security-related scripts follow the principle of least privilege

Additional Notes

[WilliamBerryiii]

Can you check out my comments, address them and then I'll kick off the build? Thanks again for the contribution!

[Richard-Jang]

I have fixed the two errors. Thank you so much for giving me the opportunity to contribute! Let me know if there are any problems.

[Richard-Jang]

@microsoft-github-policy-service agree

[WilliamBerryiii]

@Richard-Jang - I'll resolve your branch conflicts shortly (I made some heavy changes today that will need careful resolution), so your contribution is included in the 2.0 release 😁😁😁

[WilliamBerryiii]

Hi @Richard-Jang! 👋

There's a merge conflict in scripts/linting/Validate-MarkdownFrontmatter.ps1 that needs resolution. Here's how to fix it:

Steps to resolve

# 1. Fetch and merge main into your branch
git fetch upstream  # or 'origin' if you cloned microsoft/hve-core directly
git merge upstream/main

# 2. You'll see a conflict in scripts/linting/Validate-MarkdownFrontmatter.ps1

The conflict

The conflict is in the #region Main Execution block. Your PR adds try/catch wrapping (great!), while main added result normalization logic. We need to combine both.

Replace the entire conflicted section (from #region Main Execution to #endregion) with this merged version:

#region Main Execution
try {
    if ($MyInvocation.InvocationName -ne '.') {
        if ($ChangedFilesOnly) {
            $result = Test-FrontmatterValidation -ChangedFilesOnly -BaseBranch $BaseBranch -ExcludePaths $ExcludePaths -WarningsAsErrors:$WarningsAsErrors -EnableSchemaValidation:$EnableSchemaValidation -SkipFooterValidation:$SkipFooterValidation
        }
        elseif ($Files.Count -gt 0) {
            $result = Test-FrontmatterValidation -Files $Files -ExcludePaths $ExcludePaths -WarningsAsErrors:$WarningsAsErrors -EnableSchemaValidation:$EnableSchemaValidation -SkipFooterValidation:$SkipFooterValidation
        }
        else {
            $result = Test-FrontmatterValidation -Paths $Paths -ExcludePaths $ExcludePaths -WarningsAsErrors:$WarningsAsErrors -EnableSchemaValidation:$EnableSchemaValidation -SkipFooterValidation:$SkipFooterValidation
        }

        # Normalize result: if pipeline output produced an array, extract the ValidationSummary object
        # PowerShell functions can inadvertently output multiple objects; take the last (the return value)
        if ($result -is [System.Array]) {
            $result = $result | Where-Object { $null -ne $_ -and $_.GetType().GetMethod('GetExitCode') } | Select-Object -Last 1
        }

        # In ChangedFilesOnly mode with no changed files, TotalFiles=0 is a successful no-op
        if ($ChangedFilesOnly -and $null -ne $result -and $result.TotalFiles -eq 0) {
            Write-Host "✅ No changed markdown files to validate - success!" -ForegroundColor Green
            exit 0
        }

        # Validate result object before calling GetExitCode to prevent method invocation errors
        # PowerShell class methods are compiled to .NET type metadata, not stored in PSObject.Methods (ETS only)
        if ($null -eq $result -or $null -eq $result.GetType().GetMethod('GetExitCode')) {
            $resultTypeName = if ($null -eq $result) { '<null>' } else { $result.GetType().FullName }
            Write-Host "Validation did not produce a usable result object (type: $resultTypeName). Exiting with code 1."
            exit 1
        }

        $exitCode = $result.GetExitCode($WarningsAsErrors)
        if ($exitCode -ne 0) {
            exit $exitCode
        }
        else {
            Write-Host "✅ All frontmatter validation checks passed!" -ForegroundColor Green
            exit 0
        }
    }
}
catch {
    Write-Error "Validate Markdown Frontmatter failed: $($_.Exception.Message)"
    if ($env:GITHUB_ACTIONS -eq 'true') {
        Write-Output "::error::$($_.Exception.Message)"
    }
    exit 1
}
#endregion

Finish up

# 3. Stage the resolved file
git add scripts/linting/Validate-MarkdownFrontmatter.ps1

# 4. Complete the merge
git commit -m "merge: integrate upstream/main changes"

# 5. Push to your fork
git push origin main

This combines your try/catch wrapper with the result normalization logic from main. Let me know if you have any questions!

[Richard-Jang]

Hello! I've merged the changes. Let me know if there are any issues.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 9.13884% with 517 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.30%. Comparing base (2fcd595) to head (cbdfc28).

Files with missing lines	Patch %	Lines
scripts/extension/Prepare-Extension.ps1	0.69%	143 Missing ⚠️
scripts/extension/Package-Extension.ps1	0.75%	132 Missing ⚠️
scripts/linting/Markdown-Link-Check.ps1	0.00%	92 Missing ⚠️
scripts/linting/Invoke-YamlLint.ps1	0.00%	44 Missing ⚠️
scripts/security/Test-SHAStaleness.ps1	0.00%	40 Missing ⚠️
scripts/linting/Validate-MarkdownFrontmatter.ps1	4.16%	23 Missing ⚠️
scripts/lib/Get-VerifiedDownload.ps1	5.26%	18 Missing ⚠️
scripts/linting/Invoke-LinkLanguageCheck.ps1	0.00%	7 Missing ⚠️
scripts/dev-tools/Generate-PrReference.ps1	14.28%	6 Missing ⚠️
scripts/linting/Invoke-PSScriptAnalyzer.ps1	91.11%	4 Missing ⚠️
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   38.80%   38.30%   -0.51%     
==========================================
  Files          15       15              
  Lines        2814     2864      +50     
==========================================
+ Hits         1092     1097       +5     
- Misses       1722     1767      +45     

Flag	Coverage Δ
pester	38.30% <9.13%> (-0.51%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
scripts/security/Test-DependencyPinning.ps1	55.52% <85.71%> (+0.81%)	⬆️
scripts/security/Update-ActionSHAPinning.ps1	0.00% <0.00%> (ø)
scripts/linting/Invoke-PSScriptAnalyzer.ps1	93.05% <91.11%> (-5.48%)	⬇️
scripts/linting/Link-Lang-Check.ps1	0.00% <0.00%> (ø)
scripts/dev-tools/Generate-PrReference.ps1	93.96% <14.28%> (-4.24%)	⬇️
scripts/linting/Invoke-LinkLanguageCheck.ps1	0.00% <0.00%> (ø)
scripts/lib/Get-VerifiedDownload.ps1	77.77% <5.26%> (-5.12%)	⬇️
scripts/linting/Validate-MarkdownFrontmatter.ps1	60.73% <4.16%> (-1.13%)	⬇️
scripts/security/Test-SHAStaleness.ps1	0.00% <0.00%> (ø)
scripts/linting/Invoke-YamlLint.ps1	0.00% <0.00%> (ø)
... and 3 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[WilliamBerryiii]

Hey @Richard-Jang! 👋

Thank you so much for this contribution! Adding proper error handling and exit codes across our scripts is exactly the kind of foundational improvement that makes the codebase more robust and easier to maintain. This is great work, especially for a first-time contribution to the project.

I pushed a couple of small fixes to get CI green (the dot-source guards were preventing our Pester tests from loading the functions, and there was a minor PowerShell parameter issue), but the core of your work is solid and valuable.

If you enjoyed contributing here and want to continue, I'd love to point you toward a couple other repos where your skills would be welcome:

• microsoft/edge-ai – Edge AI tooling, patterns, and accelerators. Great opportunities to work on developer experience and automation.
• Azure/nvidia-robotics-accelerator – Our robotics acceleration platform on Azure. Lots of interesting infrastructure and scripting work.

Both repos have good-first-issue labels and welcoming communities. We'd love to see you contribute there too!

Thanks again for helping make hve-core better. 🎉