Convert sync over async network handling to async

[msft-paddy14]

Currently Garnet's network processing in TLS mode happens by blocking the thread that receives the packet and it waits for TLS processing to complete. This leads to threadpool exhaustion and is an anti-pattern in general. It limits scalability where cores are limited as threads will get blocked and .NET will create more threads (where limit is not set). This makes things worst as memory footprint increases (~8MB per stack) and thread contention increases. We also convert Task to ValueTask for paths where async operation is already completed in general

BDN results for Network test added

BenchmarkDotNet v0.14.0, Windows 11 (10.0.26100.2605) (Hyper-V)
AMD EPYC 7763, 1 CPU, 16 logical and 8 physical cores
.NET SDK 9.0.100
[Host] : .NET 8.0.11 (8.0.1124.51707), X64 RyuJIT AVX2
.NET 8 : .NET 8.0.11 (8.0.1124.51707), X64 RyuJIT AVX2

Job=.NET 8 EnvironmentVariables=DOTNET_TieredPGO=0 Runtime=.NET 8.0
Server=True

Without changes (Main)

Method	Params	Mean	Error	StdDev	Allocated
InlinePing	None	1.964 μs	0.0040 μs	0.0033 μs	-

Method	Params	Mean	Error	StdDev	Allocated
Set	None	14.85 μs	0.049 μs	0.046 μs	-
SetEx	None	19.87 μs	0.033 μs	0.029 μs	-
SetNx	None	18.17 μs	0.047 μs	0.039 μs	-
SetXx	None	19.00 μs	0.062 μs	0.055 μs	-
GetFound	None	15.95 μs	0.033 μs	0.031 μs	-
GetNotFound	None	11.33 μs	0.016 μs	0.014 μs	-
Increment	None	22.13 μs	0.078 μs	0.073 μs	-
Decrement	None	21.03 μs	0.045 μs	0.042 μs	-
IncrementBy	None	26.21 μs	0.069 μs	0.058 μs	-
DecrementBy	None	27.15 μs	0.064 μs	0.057 μs	-

With Changes (current PR)

Job=.NET 8 EnvironmentVariables=DOTNET_TieredPGO=0 Runtime=.NET 8.0
Server=True

Method	Params	Mean	Error	StdDev	Allocated
InlinePing	None	2.008 μs	0.0096 μs	0.0090 μs	-

Method	Params	Mean	Error	StdDev	Allocated
Set	None	14.17 μs	0.008 μs	0.007 μs	-
SetEx	None	19.74 μs	0.019 μs	0.017 μs	-
SetNx	None	17.78 μs	0.027 μs	0.025 μs	-
SetXx	None	18.41 μs	0.008 μs	0.007 μs	-
GetFound	None	15.48 μs	0.027 μs	0.024 μs	-
GetNotFound	None	11.09 μs	0.010 μs	0.009 μs	-
Increment	None	21.41 μs	0.126 μs	0.117 μs	-
Decrement	None	20.90 μs	0.037 μs	0.035 μs	-
IncrementBy	None	25.76 μs	0.063 μs	0.059 μs	-
DecrementBy	None	25.26 μs	0.025 μs	0.023 μs	-

Remaining BDN Results

AsyncBDNWithChanges.log
MainBranch.log

[badrishc]

You can also increment the Version in version.props before merge so that we get a new release with this.

[badrishc]

In RawStringOps etc. the BDN calls should be async ... await as you had it earlier. We still need that else the BDN will return before the operation completes.