Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom authentication support to Garnet. #648

Merged
merged 18 commits into from
Sep 20, 2024

Conversation

Xizt
Copy link
Contributor

@Xizt Xizt commented Sep 6, 2024

Changes to support custom authentication. Extended AuthenticationSettings by adding a custom mode which is expected to be passed during server start if custom auth mode is chosen.

@TalZaccai TalZaccai self-assigned this Sep 10, 2024
@TalZaccai TalZaccai self-requested a review September 10, 2024 18:50
@TalZaccai TalZaccai removed their assignment Sep 10, 2024
@Xizt
Copy link
Contributor Author

Xizt commented Sep 11, 2024

@microsoft-github-policy-service agree company="microsoft"

Copy link
Contributor

@vazois vazois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some changes before merging

libs/host/GarnetServer.cs Outdated Show resolved Hide resolved
@Xizt Xizt requested a review from vazois September 13, 2024 17:35
@Xizt
Copy link
Contributor Author

Xizt commented Sep 17, 2024

@badrishc @vazois There are more dependencies on the GarnetAclAuthenticator. Please do let me know the possibilities of making this class public.
One example, In RespServerSession, we have a check if the authenticator is GarnetAclAuthenticator, then user is set from aclAuthenticator otherwise set to default user. This breaks the session.
Other options I'm evaluating is exposing IGarnetAclAuthenticator interface or instead of passing entire authenticator, passing customValidator.

@badrishc badrishc merged commit ad81de1 into microsoft:main Sep 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants