fix(react-rating): Pass missing Rating's itemLabel prop to its state so RatingItem consumes it from context #33361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
packages/react-components/react-rating/library/src/components/Rating/useRating.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating/library/src/components/Rating/useRating.tsx
Outdated
Show resolved
Hide resolved
change/@fluentui-react-rating-94e96782-4be8-468e-b1a3-0b2ac9a76c62.json
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating/stories/src/Rating/RatingItemLabel.stories.tsx
Outdated
Show resolved
Hide resolved
sopranopillow
changed the title
nanabear0
force-pushed
the
rating-aria-label-fix
branch
from
21d5d51 to
f1835db
Compare
tudorpopams
requested review from
dmytrokirpa
and removed request for
marcosmoura
nanabear0
force-pushed
the
rating-aria-label-fix
branch
from
f1835db to
19aebe8
Compare
dmytrokirpa
reviewed
Dec 10, 2024
packages/react-components/react-rating/library/src/components/Rating/Rating.test.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-rating/stories/src/Rating/RatingItemLabel.stories.tsx
Outdated
Show resolved
Hide resolved
…6c62.json changelog rephrasing. Co-authored-by: Esteban Munoz Facusse <[email protected]>
nanabear0
force-pushed
the
rating-aria-label-fix
branch
from
1a06595 to
f8459e4
Compare
dmytrokirpa
approved these changes
Dec 16, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sopranopillow
approved these changes
Dec 16, 2024
fabricteam
reviewed
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The Rating component didn't use the itemLabel prop, so there wasn't an option to change aria label for the ratin items
New Behavior
Now it is correctly passing it to the RatingItemContext so aria-labels are created correcty.
Related Issue(s)