-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel: Fix autoplay and enable callback on autoplay index change #33291
Draft
Mitch-At-Work
wants to merge
3
commits into
microsoft:master
Choose a base branch
from
Mitch-At-Work:user/mifraser/enable-autoplay-callback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Carousel: Fix autoplay and enable callback on autoplay index change #33291
Mitch-At-Work
wants to merge
3
commits into
microsoft:master
from
Mitch-At-Work:user/mifraser/enable-autoplay-callback
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabricteam
reviewed
Nov 18, 2024
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
🕵 FluentUIV0 No visual regressions between this PR and main |
📊 Bundle size reportUnchanged fixtures
|
fabricteam
reviewed
Nov 18, 2024
Mitch-At-Work
force-pushed
the
user/mifraser/enable-autoplay-callback
branch
from
November 18, 2024 22:43
f1af038
to
f427173
Compare
Pull request demo site: URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
No autoplay callback making controlled scenarios not usable with autoplay.
Autoplay would start with 'stopOnInteraction' based on its autoplay value, this caused three issues:
New Behavior
Autoplay callback enables controlled autoplay callbacks
Autoplay will now be attached when enabled, by reinitializing the carousel, this ensures stopOnInteraction is respected conditionally when autoplay is either on or off.