-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bar label test cases in Horizontal bar chart #33286
Open
v-baambati
wants to merge
29
commits into
microsoft:charting/web-components
Choose a base branch
from
v-baambati:charting/web-components
base: charting/web-components
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added bar label test cases in Horizontal bar chart #33286
v-baambati
wants to merge
29
commits into
microsoft:charting/web-components
from
v-baambati:charting/web-components
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/fluentui into charting/web-components
…t/fluentui into charting/web-components
…t/fluentui into charting/web-components
Pull request demo site: URL |
AtishayMsft
reviewed
Nov 18, 2024
@@ -317,6 +317,21 @@ test.describe('horizontalbarchart - Basic', () => { | |||
await expect(page.getByText('Unmonitored')).toBeVisible(); | |||
}); | |||
|
|||
test('Should render bars and bar labels properly', async ({ page }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename the spec file to match the hyphen based naming convention used in other charts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.