Fix: updated regex validation for color theme designer input field #33148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated regex validation in order to allow only correct Hexadecimal value (only numbers from 0 to 9 and letters from A to F. Currently, when you enter incorrect hex values in the theme designer, the rendering breaks and the entire theme designer disappears.
|
@ms-acalzaretto any update ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated regex validation in order to allow only correct Hexadecimal value (only numbers from 0 to 9 and letters from A to F. Currently, when you enter incorrect hex values in the theme designer, the rendering breaks and the entire theme designer disappears.
Previous Behavior
When you enter incorrect hex values in the theme designer, the rendering breaks and the entire theme designer disappears.
Screen.Recording.2024-10-27.at.12.mp4
New Behavior
The new regex validation allows entering only numbers from 0 to 9 and letters from A to F.
Related Issue(s)
I didn't open an issue for this fix.