Implement "insertion point" API for react-shadow
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ling1726
reviewed
Jan 4, 2024
ling1726
reviewed
Jan 4, 2024
ling1726
reviewed
Jan 4, 2024
layershifter
reviewed
Jan 8, 2024
layershifter
reviewed
Jan 8, 2024
spmonahan
commented
Jan 8, 2024
spmonahan
force-pushed
the
react-shadow/insertion-point
branch
from
5f97831
to
4a13fd6
Compare
layershifter
requested changes
Jan 17, 2024
spmonahan
force-pushed
the
react-shadow/insertion-point
branch
from
4a13fd6
to
da6811b
Compare
@layershifter Made this update. |
layershifter
approved these changes
Feb 23, 2024
Allows users to control where Griffel styles are inserted into the adoptedStyleSheets array.
This function allows users to createa a root configured with options. Currently the only supported option is "insertionPoint" which allows users to control the order of stylesheets so they can affect specificity.
spmonahan
force-pushed
the
react-shadow/insertion-point
branch
from
a3b2519
to
34c313c
Compare
|
@layershifter I think I've addressed the changes we discussed. Can you remove your hold on the PR so it can be merged? |
@spmonahan I have already approved the PR previous week 🐱 
@microsoft/fluentui-react-build can you please check the PR? 🙏 |
Hotell
reviewed
Feb 29, 2024
spmonahan
force-pushed
the
react-shadow/insertion-point
branch
from
34c313c
to
33b5acb
Compare
Hotell
approved these changes
Feb 29, 2024
marcosmoura
added a commit
to marcosmoura/fluentui-contrib
that referenced
this pull request
Mar 6, 2024
* main: . applying package updates chore(react-tree-grid): release (microsoft#122) chore(react-tree-grid): follow up on a11y issue for Meet stories (microsoft#125) chore(react-tree-grid): resolve Meet stories a11y issues (microsoft#124) bugfix(react-tree-grid): header TreeGridCell should have role rowheader instead of columnheader (microsoft#123) chore(react-tree-grid): minor adjustments on stories (microsoft#117) Implement "insertion point" API for `react-shadow` (microsoft#60) create houdini-utils package (microsoft#120) feat(nx-plugin): add testEnvironment to library generator and render proper jest config (microsoft#121) chore(react-tree-grid): adds playwright component tests (microsoft#100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an "insertion point" API similar to Griffel's API.
Here we use a special sentinel
ExtendedCSSStyleSheetin theadoptedStyleSheetsarray and look it up prior to setting the stylesheets.Additionally, a constant for whetheradoptedStyleSheetsis mutable is added so we can conditionally update the array. This improves Safari support. See this PR for more details.Resolves #59