feat(react-keytips): initial implementation #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainframev
force-pushed
the
keytips-draft
branch
8 times, most recently
from
9a62bef
to
1070231
Compare
mainframev
force-pushed
the
keytips-draft
branch
5 times, most recently
from
efebf06
to
9e76165
Compare
mainframev
force-pushed
the
keytips-draft
branch
6 times, most recently
from
943879f
to
7eeef21
Compare
mainframev
commented
Sep 23, 2024
| <Keytip key={keytipId} {...keytipProps} /> | ||
| )); | ||
|
|
||
| const hiddenKeytips = Object.values(keytips).map(({ keySequences }) => ( |
There was a problem hiding this comment.
this is similar to v8 keytips implementation and needed for maintaining ids for aria-describedby
mainframev
force-pushed
the
keytips-draft
branch
from
7eeef21
to
136074e
Compare
dmytrokirpa
reviewed
Sep 25, 2024
…e, import from there
mainframev
force-pushed
the
keytips-draft
branch
from
93abd85
to
352e4ee
Compare
dmytrokirpa
reviewed
Oct 14, 2024
Co-authored-by: Dmytro Kirpa <[email protected]>
dmytrokirpa
approved these changes
Oct 14, 2024
mainframev
force-pushed
the
keytips-draft
branch
from
2a21db7
to
a980a55
Compare
Hotell
reviewed
Oct 15, 2024
change/@fluentui-contrib-react-keytips-2c77a34b-1b5c-4d63-a244-ad06854777c9.json
Outdated
Show resolved
Hide resolved
Hotell
reviewed
Oct 15, 2024
…-ad06854777c9.json Co-authored-by: Martin Hochel <[email protected]>
1 task
Hotell
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for persistent keytips will be added later. This PR covers draft and initial implementation.