Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-chat): change ChatMessage/ChatMyMessage to new slot api #112

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

YuanboXue-Amber
Copy link
Contributor

@YuanboXue-Amber YuanboXue-Amber commented Feb 20, 2024

as title

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review February 20, 2024 18:29
@YuanboXue-Amber YuanboXue-Amber requested a review from a team as a code owner February 20, 2024 18:29
@YuanboXue-Amber YuanboXue-Amber merged commit 745ac81 into microsoft:main Feb 21, 2024
4 checks passed
Comment on lines +1 to +5
/** @jsxRuntime classic */
/** @jsx createElement */

// eslint-disable-next-line @typescript-eslint/no-unused-vars
import { createElement } from '@fluentui/react-jsx-runtime';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/** @jsxRuntime automatic */
/** @jsxImportSource @fluentui/react-jsx-runtime */

Why don't use proper jsxRuntime?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hotell when using proper jsxRuntime storybook breaks, is it related to #93?

marcosmoura added a commit to marcosmoura/fluentui-contrib that referenced this pull request Feb 21, 2024
…og' into test/react-draggable-dialog/add-tests-for-DraggableDialogSurface

* test/react-draggable-dialog/add-tests-for-DraggableDialog:
  fix: prop name
  test(react-draggable-dialog): add basic test cases (microsoft#107)
  applying package updates
  chore(react-chat): change ChatMessage/ChatMyMessage to new slot api (microsoft#112)
  chore(react-chat): use composition hook for Chat (microsoft#104)
  chore(react-tree-grid): creates stories for better documenting (microsoft#108)
  chore(deps): bump ip from 2.0.0 to 2.0.1 (microsoft#113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants