Implementing Repository Management actions + Database changes. #3836

dhoehna · 2024-09-11T17:35:52Z

Summary of the pull request

This PR allows users to

Remove the repository from the list
Delete the Repository
Run the repositories WinGet configuration file
Make a new WinGet configuration file with the selected repository
Open FE to the repository root
Open CCMD to the repository root
Add an existing repository to the list
Navigate to the clone repository flow.

All from the repository management page! Yay!

In addition to logic changes. I made some database changes

Removed RepositoryMetadata. IsHidden is part of the Repository entity
Moved RepositoryManagementDataAccessService to DevHome.Database to prevent a circular dependency. Now I can call MakeConfigurationFileFromRepoAndGit without moving the code base to a new project.
Added another Repository test.
Added the following to Repository
1. RepositoryClonePath
2. HasConfigurationFile
3. ConfigurationFileLocation
4. RepositoryUri

Another change is in Navigation. Changed navigation to use a Dictionary instead of multiple if/else.

References and relevant issues

Detailed description of the pull request / Additional comments

This PR has many TODO:'s and they will be removed in another PR this week as I address them.
This feature is still experimental.

Validation steps performed

PR checklist

Closes #xxx
[X ] Tests added/passed
Documentation updated

* Adding the Repository tool * WIP * View is set up. Test ata as well. * Aligning columns. Adding column spacing. * Reverting this change * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Strings/en-us/Resources.resw Co-authored-by: Kristen Schau <[email protected]> * Adressing comments * Revert "Reverting this change" This reverts commit 711dd78. * Moving to experimental * Disabling by default * Removing from experimental. Addressing comments. * Reverting to main * Update tools/RepositoryManagement/DevHome.RepositoryManagement/DevHome.RepositoryManagement.csproj Co-authored-by: Kristen Schau <[email protected]> * Update tools/RepositoryManagement/DevHome.RepositoryManagement/Extensions/ServiceExtensions.cs Co-authored-by: Kristen Schau <[email protected]> * Removing duplicate xaml code * Adding to the mermaid diagram * Got lost in the shuffle * Removing a refrence --------- Co-authored-by: Kristen Schau <[email protected]>

* WIP * EF works. Can save data. * Can read and write. :) * Repos are added when cloned. * Putting save/load into a different class * Adding default values * Cleaning up names and using statements * More comments * Removing refrence to the public nuget * Restoring the nuget config * Adding a test. Better defining dates * Adding some tests * More comments. * Better path comparison. * Removing unused equals code * Adding more comments. Making new migrations

…thub.com/microsoft/devhome into user/dhoehna/RepositoryManagementFeature

common/Services/INavigationService.cs

common/TelemetryEvents/DevHomeDatabase/DevHomeDatabaseContextEvent.cs

common/TelemetryEvents/RepositoryManagement/RepositoryLineItemErrorEvent.cs

common/TelemetryEvents/RepositoryManagement/RepositoryLineItemEvent.cs

database/DevHome.Database/DatabaseModels/RepositoryManagement/Repository.cs

...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs

…Repository.cs Co-authored-by: Branden Bonaby <[email protected]>

...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs

vineeththomasalex · 2024-09-18T21:34:04Z

common/Services/INavigationService.cs

@@ -49,4 +49,7 @@ public static class KnownPageKeys
 public static readonly string Feedback = "DevHome.Settings.ViewModels.FeedbackViewModel";
 public static readonly string Environments = "DevHome.Environments.ViewModels.LandingPageViewModel";
 public static readonly string SetupFlow = "DevHome.SetupFlow.ViewModels.SetupFlowViewModel";
+
+ // Will not work with navigation service natively. Used for the dictionary in SetupFlowViewModel
+ public static readonly string RepositoryConfiguration = "RepositoryConfiguration";


Would the full path not work here? I'm not able to figure out why this breaks the pattern above. If it's only used in a specific place, maybe it doesn't need to be in the KnownPageKeys list? Not sure

vineeththomasalex · 2024-09-18T21:37:39Z

common/TelemetryEvents/DevHomeDatabase/DevHomeDatabaseEvent.cs

+namespace DevHome.Common.TelemetryEvents.DevHomeDatabase;
+
+[EventData]
+public class DevHomeDatabaseEvent : EventBase


Nit: Lets not prepend DevHome to any names.

Suggested change

public class DevHomeDatabaseEvent : EventBase

public class DatabaseEvent : EventBase

Is DatabaseEvent verbose enough to pinpoint the event? Maybe we can rename it. Same comments about DevHomeDatabaseContextEvent .

vineeththomasalex · 2024-09-18T21:39:55Z

database/DevHome.Database/DevHomeDatabaseContext.cs

 public class DevHomeDatabaseContext : DbContext
 {
- public DbSet<Repository> Repositories { get; set; }
+ private const string DatabaseFileName = "DevHome.db";


Should probably add a Const value for this file name/path and add it somewhere central (like config?).

Nit: I'm also not a fan of the name "DevHome.db". Mabye something like "DevHomeMachineData.db" to reflect that this is data about what's on the machine (at least that's what I think this is for) :)

vineeththomasalex · 2024-09-18T21:42:58Z

database/DevHome.Database/DevHomeDatabaseContext.cs

+ repositoryEntity.Property(x => x.RepositoryClonePath).HasDefaultValue(string.Empty).IsRequired(true);
+ repositoryEntity.Property(x => x.RepositoryName).HasDefaultValue(string.Empty).IsRequired(true);
+ repositoryEntity.Property(x => x.CreatedUTCDate).HasDefaultValueSql("datetime()");
+ repositoryEntity.Property(x => x.UpdatedUTCDate).HasDefaultValue(new DateTime(1, 1, 1, 0, 0, 0, DateTimeKind.Utc));


Is this to indicate when the Repo was updated locally? If so, it might need to be the same as CreatedUTCDate. I guess it depends on how it's used.

vineeththomasalex · 2024-09-18T21:44:28Z

common/TelemetryEvents/DevHomeDatabase/DevHomeDatabaseContextEvent.cs

+ Action = action;
+ }
+
+ public DevHomeDatabaseContextEvent(string action, Exception ex)


Nit: I just realized that this is a failure event. Maybe the name needs to be changed to reflect that this is an error.

vineeththomasalex · 2024-09-18T21:54:35Z

database/DevHome.Database/Services/RepositoryManagementDataAccessService.cs

+ var existingRepository = GetRepository(repositoryName, cloneLocation);
+ if (existingRepository != null)
+ {
+ _log.Information($"A Repository with name {repositoryName} and clone location {cloneLocation} exists in the repository already.");


Nit: Should be error/warning if this causes MakeRepository() to fail.

vineeththomasalex · 2024-09-18T22:00:55Z

tools/SetupFlow/DevHome.SetupFlow/ViewModels/SetupFlowViewModel.cs

@@ -43,6 +44,10 @@ public SetupFlowViewModel(
 SetupFlowOrchestrator orchestrator,
 PackageProvider packageProvider)
 {
+ _navigationTargets.Add(_creationFlowNavigationParameter, StartCreationFlow);
+ _navigationTargets.Add("StartQuickstartPlayground", StartQuickStartFlow);


Nit: Can add _quickstartNavigationParameter back in and replace this

vineeththomasalex · 2024-09-18T22:03:44Z

...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs

+ private void SendTelemetryAndLogError(string operation, Exception ex)
+ {
+ TelemetryFactory.Get<ITelemetry>().LogError(
+ ErrorEventName,


Better to just add the "DevHome_RepositoryLineItemError_Event" string here and delete the class var.

vineeththomasalex · 2024-09-18T22:04:17Z

...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs

+ {
+ _log.Error(ex, $"Cound not move repository to the selected location.");
+ TelemetryFactory.Get<ITelemetry>().Log(
+ EventName,


Same comment as the other event. No need for this variable.

vineeththomasalex · 2024-09-18T22:05:15Z

database/DevHome.Database/Services/RepositoryManagementDataAccessService.cs

+
+public class RepositoryManagementDataAccessService
+{
+ private const string EventName = "DevHome_RepositoryData_Event";


IMO we should just use the string directly in the Telemetry call, since that's clearer.

vineeththomasalex · 2024-09-18T22:11:36Z

database/DevHome.Database/Services/RepositoryManagementDataAccessService.cs

+ }
+ catch (Exception ex)
+ {
+ _log.Error(ex, "Exception when updating the clone location.");


Nit:

Suggested change

_log.Error(ex, "Exception when updating the clone location.");

_log.Error(ex, "Exception when removing the repository.");

vineeththomasalex · 2024-09-18T22:12:30Z

database/DevHome.Database/Services/RepositoryManagementDataAccessService.cs

+ }
+ catch (Exception ex)
+ {
+ _log.Error(ex, "Exception when updating the clone location.");


Nit:

Suggested change

_log.Error(ex, "Exception when updating the clone location.");

_log.Error(ex, "Exception when setting repository hidden status.");

vineeththomasalex

LGTM, nothing blocking, and TODO's are being taken care of in https://github.com/microsoft/devhome/tree/user/dhoehna/DatabaseMigrationsAndTodos

dhoehna and others added 30 commits August 13, 2024 12:23

Merge branch 'main' into user/dhoehna/RepositoryManagementFeature

e52afbf

Merge branch 'main' into user/dhoehna/RepositoryManagementFeature

cd2f925

Merge branch 'user/dhoehna/RepositoryManagementFeature' of https://gi…

6775301

…thub.com/microsoft/devhome into user/dhoehna/RepositoryManagementFeature

Moving this to experimental

9d77f68

WIP

17cc488

Some telemetry and logging

66f6978

THings build again.

8606981

Returning this back

241bcee

I believe I am understanding this.

234af67

Can update

038c65b

Almost done with open in FE

e45e669

Try/Catching everything. Open in FE should be done.

0d39cd6

Open in CMD works. :)

d6f4f44

Merge branch 'main' into user/dhoehna/ImplementingTheRepositoryActions

e3b552e

Re-adding changes lost due to merge

1d628c7

Getting saving straightened out.

d23a431

Merge branch 'main' into user/dhoehna/ImplementingTheRepositoryActions

6b7b72e

WIP

d73857d

Move Repository done.

87a1a38

Removing 1:1. Finishing RemoveFromList

5395f4c

Adding _items

022977a

Adding configuration file information to the repository table

7fe619c

Opening the configuration file location in FE

5655157

Deleting a repository.

2ef3922

Add to winget configuration file.

2c44c31

Cleaning up the code

cfa8f9a

Icon for a configuration file. UI updates when hiding a repo

0c00fca

All the buttons do something.

4135ec4

dhoehna requested review from lauren-ciha, zadesai, SohamDas2021, AmelBawa-msft, bbonaby, ssparach and a team September 11, 2024 17:35

krschau added this to the Dev Home v0.19 milestone Sep 11, 2024

Changing a comment

f30435e

bbonaby reviewed Sep 13, 2024

View reviewed changes

dhoehna and others added 4 commits September 16, 2024 11:44

Update database/DevHome.Database/DatabaseModels/RepositoryManagement/…

f674f74

…Repository.cs Co-authored-by: Branden Bonaby <[email protected]>

Comments

2a09abe

Merge branch 'main' into user/dhoehna/ImplementingTheRepositoryActions

689e310

Don't just merge code and expect things to work.

36a9009

bbonaby reviewed Sep 17, 2024

View reviewed changes

...itoryManagement/DevHome.RepositoryManagement/ViewModels/RepositoryManagementItemViewModel.cs Outdated Show resolved Hide resolved

What is in a name?

fc6fca5

bbonaby approved these changes Sep 18, 2024

View reviewed changes

vineeththomasalex reviewed Sep 18, 2024

View reviewed changes

vineeththomasalex approved these changes Sep 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing Repository Management actions + Database changes. #3836

Implementing Repository Management actions + Database changes. #3836

dhoehna commented Sep 11, 2024 •

edited

Loading

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024 •

edited

Loading

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex Sep 18, 2024

vineeththomasalex left a comment

	public class DevHomeDatabaseEvent : EventBase
	public class DatabaseEvent : EventBase

	_log.Error(ex, "Exception when updating the clone location.");
	_log.Error(ex, "Exception when removing the repository.");

	_log.Error(ex, "Exception when updating the clone location.");
	_log.Error(ex, "Exception when setting repository hidden status.");

Implementing Repository Management actions + Database changes. #3836

Are you sure you want to change the base?

Implementing Repository Management actions + Database changes. #3836

Conversation

dhoehna commented Sep 11, 2024 • edited Loading

Summary of the pull request

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vineeththomasalex Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vineeththomasalex left a comment

Choose a reason for hiding this comment

dhoehna commented Sep 11, 2024 •

edited

Loading

vineeththomasalex Sep 18, 2024 •

edited

Loading