Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch from SSH widget to Terminal if available #3730

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Aug 29, 2024

Summary of the pull request

Try launching via Terminal first. If Terminal isn't available, fall back to cmd. Uses the default profile. In the future, we could potentially give users the option to set a profile per-widget.

Validation steps performed

Validated locally.

PR checklist

Comment on lines +153 to +154
FileName = "wt.exe",
Arguments = $"ssh {args.Data}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FileName = "wt.exe",
Arguments = $"ssh {args.Data}",
FileName = "ssh.exe",
Arguments = $"{args.Data}",

(then you cam probably also drop the fallback below)

This will let the OS spawn ssh in the user's default terminal app, regardless of if it's set to Terminal or conhost.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original change from cmd to wt, I got to remove the /k switch that keeps the window open. Do you know if there's something I can pass into ssh.exe to do the same thing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. That's a good question. The terminal has the closeOnExit setting, which is perfect for keeping the window open when ssh disconnects, but that isn't going to help conhost at all.

I suppose you could always just run cmd /k ssh {{whatever}}. Launching cmd directly will do the same thing - boot into whatever your default terminal is.

In my totally biased opinion though, I'd just launch ssh.exe directly. If the users want the console window to stay open after the session disconnects, then "here's a nickel kid, go get yourself a modern Terminal (and stop using conhost)"

@krschau krschau marked this pull request as draft September 11, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH Keychain Widget Opens in CMD
4 participants