-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StyleCop #2162
Update StyleCop #2162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking while I check on the copyright thing.
tools/SetupFlow/DevHome.SetupFlow.Common/Elevation/RemoteObject`1.cs
Outdated
Show resolved
Hide resolved
Woow! Fixed! Didn't expect those line ending changes. The files below have been changed from
|
I'm really sorry but I had to update the headers, and this caused a bunch of conflicts for you. Hopefully they're not too painful to resolve. |
Aligned the branch with main keeping the new header and fixed StyleCop errors. |
Oh jeez🤦♀️Thanks for fixing those instances. |
Summary of the pull request
Updated StyleCop to the latest version to improve compatibility with latest .NET/C# feature.
References and relevant issues
#1259
Detailed description of the pull request / Additional comments
Added file header to.editorconfig
to automatically add it to new.cs
files.GlobalSuppressions.cs
GlobalSuppressions.cs
(nice to have but with high impact in changes)Validation steps performed
PR checklist