Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting gulp task #25705

Closed
wants to merge 2 commits into from
Closed

Porting gulp task #25705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8fa438
Adding gulp task that adds ads metadata to exe file. (#25665)
aasimkhan30 Jun 4, 2024
23c0849
Removing ESRP references in pipelines
Benjin Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions build/azure-pipelines/darwin/sql-product-build-darwin-signing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,55 +17,11 @@ steps:
mv azuredatastudio-darwin-$(VSCODE_ARCH)-unsigned.zip azuredatastudio-darwin-$(VSCODE_ARCH).zip
displayName: 'Rename the file'

- task: EsrpCodeSigning@3
displayName: 'ESRP CodeSigning'
inputs:
ConnectedServiceName: 'Code Signing'
FolderPath: '$(Build.SourcesDirectory)/.build/drop/darwin/archive'
Pattern: 'azuredatastudio-darwin-$(VSCODE_ARCH).zip'
signConfigType: inlineSignParams
inlineOperation: |
[
{
"keyCode": "CP-401337-Apple",
"operationCode": "MacAppDeveloperSign",
"parameters": {
"Hardening": "Enable"
},
"toolName": "sign",
"toolVersion": "1.0"
}
]
SessionTimeout: 90
condition: and(succeeded(), eq(variables['signed'], true))

- script: |
zip -d $(Build.SourcesDirectory)/.build/drop/darwin/archive/azuredatastudio-darwin-$(VSCODE_ARCH).zip "*.pkg"
displayName: Clean Archive
condition: and(succeeded(), eq(variables['signed'], true))

- task: EsrpCodeSigning@3
displayName: 'ESRP Notarization'
inputs:
ConnectedServiceName: 'Code Signing'
FolderPath: '$(Build.SourcesDirectory)/.build/drop/darwin/archive'
Pattern: 'azuredatastudio-darwin-$(VSCODE_ARCH).zip'
signConfigType: inlineSignParams
inlineOperation: |
[
{
"KeyCode": "CP-401337-Apple",
"OperationCode": "MacAppNotarize",
"Parameters": {
"BundleId": "com.microsoft.azuredatastudio-$(VSCODE_QUALITY)"
},
"ToolName": "sign",
"ToolVersion": "1.0"
}
]
SessionTimeout: 120
condition: and(succeeded(), eq(variables['signed'], true))

- task: CopyFiles@2
displayName: 'Copy Files to: $(Build.ArtifactStagingDirectory)/darwin/archive'
inputs:
Expand Down
29 changes: 8 additions & 21 deletions build/azure-pipelines/darwin/sql-product-build-darwin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
steps:
- task: InstallAppleCertificate@2
displayName: 'Install developer certificate'
inputs:
certSecureFile: 'osx_signing_key.p12'
condition: eq(variables['signed'], true)

- task: DownloadPipelineArtifact@2
inputs:
artifact: Compilation
Expand All @@ -28,20 +22,13 @@ steps:
versionSpec: '3.11.x'
addToPath: true

- task: AzureKeyVault@1
displayName: 'Azure Key Vault: Get Secrets'
inputs:
azureSubscription: 'ADS Pipelines'
KeyVaultName: ado-secrets
SecretsFilter: 'github-distro-mixin-password'

- script: |
set -e

cat << EOF > ~/.netrc
machine github.com
login azuredatastudio
password $(github-distro-mixin-password)
password $(Github-Mixin-Password)
EOF

git config user.email "[email protected]"
Expand Down Expand Up @@ -82,7 +69,7 @@ steps:
CHILD_CONCURRENCY=1 yarn --frozen-lockfile
displayName: Install dependencies
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))

- script: |
Expand Down Expand Up @@ -110,16 +97,16 @@ steps:
yarn gulp vscode-darwin-$(VSCODE_ARCH)-min-ci
displayName: Build
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
VSCODE_MIXIN_PASSWORD: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
VSCODE_MIXIN_PASSWORD: $(Github-Mixin-Password)
condition: and(succeeded(), ne(variables['VSCODE_ARCH'], 'universal'))

- script: |
set -e
./scripts/test.sh --build --tfs "Unit Tests" --coverage
displayName: Run unit tests
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), eq(variables['RUN_TESTS'], 'true'))

- script: |
Expand All @@ -134,7 +121,7 @@ steps:
./scripts/test-integration.sh --build --tfs "Integration Tests"
displayName: Run core integration tests
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), eq(variables['RUN_TESTS'], 'true'))

- script: |
Expand All @@ -153,7 +140,7 @@ steps:
displayName: Run core smoke tests (Continue on Error)
continueOnError: true
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), and(or(eq(variables['RUN_TESTS'], 'true'), eq(variables['RUN_SMOKE_TESTS'], 'true')), ne(variables['SMOKE_FAIL_ON_ERROR'], 'true')))

- script: |
Expand All @@ -163,7 +150,7 @@ steps:
yarn smoketest --build "$APP_ROOT/$APP_NAME" --log "$(build.artifactstagingdirectory)/logs/darwin/smoke.log" --extensionsDir "$(build.sourcesdirectory)/extensions"
displayName: Run core smoke tests (Fail on Error)
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), and(or(eq(variables['RUN_TESTS'], 'true'), eq(variables['RUN_SMOKE_TESTS'], 'true')), eq(variables['SMOKE_FAIL_ON_ERROR'], 'true')))

# - script: |
Expand Down
82 changes: 8 additions & 74 deletions build/azure-pipelines/linux/sql-product-build-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,6 @@ steps:
inputs:
versionSpec: "1.x"

- task: AzureKeyVault@1
displayName: 'Azure Key Vault: Get Secrets'
inputs:
azureSubscription: 'ADS Pipelines'
KeyVaultName: ado-secrets
SecretsFilter: 'github-distro-mixin-password'

- task: DownloadPipelineArtifact@2
inputs:
artifact: Compilation
Expand All @@ -34,7 +27,7 @@ steps:
cat << EOF > ~/.netrc
machine github.com
login azuredatastudio
password $(github-distro-mixin-password)
password $(Github-Mixin-Password)
EOF

git config user.email "[email protected]"
Expand Down Expand Up @@ -74,7 +67,7 @@ steps:
CHILD_CONCURRENCY=1 yarn --frozen-lockfile
displayName: Install dependencies
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))

- script: |
Expand All @@ -101,8 +94,8 @@ steps:
yarn gulp vscode-linux-x64-min-ci
displayName: Build
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
VSCODE_MIXIN_PASSWORD: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
VSCODE_MIXIN_PASSWORD: $(Github-Mixin-Password)

- script: |
set -e
Expand All @@ -127,7 +120,7 @@ steps:
DISPLAY=:10 ./scripts/test.sh --build --tfs "Unit Tests" --coverage
displayName: Run core unit tests
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), eq(variables['RUN_TESTS'], 'true'), ne(variables['EXTENSIONS_ONLY'], 'true'))

- script: |
Expand All @@ -142,7 +135,7 @@ steps:
DISPLAY=:10 ./scripts/test-integration.sh --build --tfs "Integration Tests"
displayName: Run core integration tests
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), eq(variables['RUN_TESTS'], 'true'), ne(variables['EXTENSIONS_ONLY'], 'true'))

- script: |
Expand All @@ -159,7 +152,7 @@ steps:
displayName: Run Extension Unit Tests (Continue on Error)
continueOnError: true
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), and(eq(variables['RUN_TESTS'], 'true'), eq(variables['EXTENSION_UNIT_TESTS_FAIL_ON_ERROR'], 'false')))

- script: |
Expand All @@ -175,7 +168,7 @@ steps:
DISPLAY=:10 ./scripts/test-extensions-unit.sh --build --tfs "Extension Unit Tests"
displayName: Run Extension Unit Tests (Fail on Error)
env:
GITHUB_TOKEN: $(github-distro-mixin-password)
GITHUB_TOKEN: $(Github-Mixin-Password)
condition: and(succeeded(), and(eq(variables['RUN_TESTS'], 'true'), ne(variables['EXTENSION_UNIT_TESTS_FAIL_ON_ERROR'], 'false')))

- bash: |
Expand Down Expand Up @@ -216,65 +209,6 @@ steps:
displayName: Build rpm package
condition: and(succeeded(), ne(variables['EXTENSIONS_ONLY'], 'true'))

- task: UseDotNet@2
displayName: 'Install .NET SDK for signing'
inputs:
packageType: sdk
version: 6.0.x
installationPath: $(Agent.ToolsDirectory)/dotnet

- task: EsrpCodeSigning@3
inputs:
ConnectedServiceName: 'Code Signing'
FolderPath: '$(Build.SourcesDirectory)/.build/linux'
Pattern: 'deb/*.deb, rpm/*.rpm'
signConfigType: inlineSignParams
inlineOperation: |
[
{
"KeyCode": "CP-500207-Pgp",
"OperationCode": "LinuxSign",
"Parameters": {},
"ToolName": "sign",
"ToolVersion": "1.0"
}
]
SessionTimeout: 120
displayName: 'Signing deb and rpm'
condition: and(succeeded(), ne(variables['EXTENSIONS_ONLY'], 'true'), eq(variables['signed'], true))

- task: EsrpCodeSigning@3
inputs:
ConnectedServiceName: 'Code Signing'
FolderPath: '$(Build.SourcesDirectory)/.build'
Pattern: 'extensions/*.vsix,langpacks/*.vsix'
signConfigType: inlineSignParams
inlineOperation: |
[
{
"keyCode": "CP-233016",
"operationSetCode": "OpcSign",
"parameters": [
{
"parameterName": "FileDigest",
"parameterValue": "/fd \"SHA256\""
}
],
"toolName": "sign",
"toolVersion": "1.0"
},
{
"keyCode": "CP-233016",
"operationSetCode": "OpcVerify",
"parameters": [],
"toolName": "sign",
"toolVersion": "1.0"
}
]
SessionTimeout: 120
displayName: 'Signing Extensions and Langpacks'
condition: and(succeeded(), eq(variables['signed'], true))

- script: |
set -e
./build/azure-pipelines/linux/createDrop.sh
Expand Down
Loading
Loading