Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow PNG icons in gallery and use commit link for pieces-azure-data-studio #25181

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Charles-Gagnon
Copy link
Contributor

VS Code requires PNG (since SVGs can contain code) so enforcing that for us as well.

Also updating the pieces-azure-data-studio extension to use a direct commit link n(follow up from #25173) to reduce the chance of changes to master breaking the gallery. I'm trying to think of a good way to enforce this as well and will follow up with adding a check for that if I come up with one - but for now we'll just ask people to update them as they submit new extensions.

FYI @caleb-at-pieces

Copy link

github-actions bot commented Jan 9, 2024

MSFT Gallery Maintainer Only
This is a reminder to update the Extensions Gallery list at https://github.com/Microsoft/azuredatastudio/wiki/List-of-Extensions once this PR has been merged in.
Instructions for doing this can be found here.

@caleb-at-pieces
Copy link

Thank you! @Charles-Gagnon

@Charles-Gagnon Charles-Gagnon merged commit 9f10e0f into release/extensions Jan 9, 2024
4 checks passed
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/checkPng branch January 9, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants