Bugfix - Retrieve Settings from KV map

[beejones]

There was a bug in retrieving the settings from the KV map which is fixed. As a result the default was always used which resulted in debug log not being logged.
New unit tests added
Added unit tests command to makefile

[beejones]

tests:
https://github.com/microsoft/privacy-sandbox-dev/actions/runs/11935821287

[DomAyre]

It looks like we have added a new endpoint, regarding that:

• Based on the test expectation, the output looks like it returns very similar to /heartbeat what is the distinction?
• Can we add system tests for it? I tried to use it locally, not sure if I'm missing something? I ran /heartbeat after to ensure the network was up correctly

@DomAyre ➜ /workspaces/azure-privacy-sandbox-kms (test-ronny) $ make start-host-idp
stop-host
source ./scripts/ccf/sandbox-local/down.sh
stop-idp
source ./scripts/jwt-issuer/down.sh
[+] Running 1/0
 ✔ Container services-jwt-issuer-1  Removed                                                                                                                       0.0s 
start-idp
source ./scripts/jwt-issuer/up.sh
[+] Running 1/1
 ✔ Container services-jwt-issuer-1  Healthy                                                                                                                       2.0s 
start-host
MEMBER_COUNT=3 source ./scripts/ccf/sandbox-local/up.sh && \
source ./scripts/kms/js-app-set.sh && \
source ./scripts/kms/constitution-set.sh ./governance/constitution/kms_actions.js
[+] Running 1/1
 ✔ Container services-ccf-sandbox-1  Healthy                                                                                                                      3.1s 
{
  "WORKSPACE": "/workspaces/azure-privacy-sandbox-kms/workspace",
  "KMS_URL": "https://127.0.0.1:8000",
  "KMS_SERVICE_CERT_PATH": "/workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/service_cert.pem",
  "KMS_MEMBER_CERT_PATH": "/workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/member0_cert.pem",
  "KMS_MEMBER_PRIVK_PATH": "/workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/member0_privk.pem"
}

up to date, audited 832 packages in 4s

88 packages are looking for funding
  run `npm fund` for details

4 vulnerabilities (3 low, 1 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> build
> rm -rf ./dist/ && rollup --config && cp app.json dist/ && node build_bundle.js dist/


src/index.ts → dist/src...
created dist/src in 6.3s
Writing bundle containing 63 modules to dist/bundle.json
Proposing: /workspaces/azure-privacy-sandbox-kms/workspace/proposals/set_js_app.json
  to https://127.0.0.1:8000
    cert: /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/service_cert.pem
  as /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/member0_cert.pem
{
  "ballot_count": 0,
  "proposal_id": "d86d3f3ddd6d7d18f1b514767dd006577cd4a7a7c035779072ab5b18809fc168",
  "proposer_id": "cff9ff64886712c161c63dd118a9be6ea19f4bc289f6a72fc9c325caaaae0fea",
  "state": "Accepted",
  "votes": {}
}
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 48068  100 48068    0     0  1738k      0 --:--:-- --:--:-- --:--:-- 1805k
Proposing: /workspaces/azure-privacy-sandbox-kms/workspace/proposals/set_constitution.json
  to https://127.0.0.1:8000
    cert: /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/service_cert.pem
  as /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/member0_cert.pem
{
  "ballot_count": 0,
  "proposal_id": "10558746788b5e5b9deeefed6db3b51ada56e5ae3d1cf33f76903c29734db7c4",
  "proposer_id": "cff9ff64886712c161c63dd118a9be6ea19f4bc289f6a72fc9c325caaaae0fea",
  "state": "Accepted",
  "votes": {}
}
start-host-idp
Executing: 
MEMBER_COUNT=3 source ./scripts/ccf/sandbox-local/up.sh > /dev/null 2>&1 && \
source ./scripts/kms/jwt-issuer-trust.sh
Proposing: /workspaces/azure-privacy-sandbox-kms/workspace/proposals/set_jwt_issuer.json
  to https://127.0.0.1:8000
    cert: /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/service_cert.pem
  as /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/member0_cert.pem
{
  "ballot_count": 0,
  "proposal_id": "0d6fef71560b991c2871d89bd6c669309aac42a34a90124595543107ad13c56b",
  "proposer_id": "cff9ff64886712c161c63dd118a9be6ea19f4bc289f6a72fc9c325caaaae0fea",
  "state": "Accepted",
  "votes": {}
}
@DomAyre ➜ /workspaces/azure-privacy-sandbox-kms (test-ronny) $ curl -k https://127.0.0.1:8000/app/settingsPolicy --cacert /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/service_cert.pem --cert /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/member0_cert.pem --key /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/member0_privk.pem -H "Content-Type: application/json"
{"error":{"code":"InternalError","message":"Exception thrown while executing."}}
@DomAyre ➜ /workspaces/azure-privacy-sandbox-kms (test-ronny) $ curl -k https://127.0.0.1:8000/app/heartbeat --cacert /workspaces/azure-privacy-sandbox-kms/workspace/s
andbox_common/service_cert.pem --cert /workspaces/azure-privacy-sandbox-kms/workspace/sandbox_common/member0_cert.pem --key /workspaces/azure-privacy-sandbox-kms/works
pace/sandbox_common/member0_privk.pem -H "Content-Type: application/json"
{"description":["azure-privacy-sandbox-kms","Key Management Service","1.0.0","false"]}

Update: I guess from reading further I need to submit the set_settings_policy proposal? I think we should get some default policy if none has been set

[DomAyre]

nit: spacing