-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system level testing which can be run locally and in C-ACI #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomAyre
changed the title
Add system level testing which can be run locally and C-ACI
Add system level testing which can be run locally and in C-ACI
Oct 17, 2024
…dbox-kms into system-tests
Since running in ACI for CI is a bit flaky and we don't want to block fixing the issues, I suggest we merge this as is @beejones if you're happy with this? |
beejones
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be down-streamed to forks.
Todo:
UPDATE: deferring for future PR
Issues found so far (currently more nitpicks and probably aren't blockers):
/hearthbeat
#168/keyReleasePolicy
returns 500 when no key release policy is set #175/keyReleasePolicy
returns potentially unexpected values #176/key
endpoint ignores the body fieldwrappingKey
#179