Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to read a null response when getting a federated token #316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't try to read a null response when getting a federated token #316

wants to merge 2 commits into from

Conversation

winstliu
Copy link
Member

If response is null on L68, you can bet response.oidcToken is going to throw on L72...

@winstliu winstliu requested a review from a team as a code owner May 26, 2024 19:26
@tintse-thxsky-MSFT
Copy link
Contributor

LGTM

@winstliu
Copy link
Member Author

Thanks for the review! Can someone also merge this please? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintse-thxsky-MSFT tintse-thxsky-MSFT tintse-thxsky-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winstliu @tintse-thxsky-MSFT