-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent name termination #4123
Merged
Merged
Agent name termination #4123
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
ekzhu
reviewed
Nov 12, 2024
python/packages/autogen-ext/src/autogen_ext/task/_agent_name_termination.py
Outdated
Show resolved
Hide resolved
ekzhu
reviewed
Nov 12, 2024
python/packages/autogen-ext/src/autogen_ext/task/_agent_name_termination.py
Outdated
Show resolved
Hide resolved
ekzhu
reviewed
Nov 12, 2024
python/packages/autogen-ext/src/autogen_ext/task/_agent_name_termination.py
Outdated
Show resolved
Hide resolved
- Rename class to `SourceMatchTermination`
ekzhu
reviewed
Nov 13, 2024
python/packages/autogen-ext/src/autogen_ext/task/_source_match_termination.py
Outdated
Show resolved
Hide resolved
thainduy
force-pushed
the
ext-AgentNameTermination
branch
from
November 13, 2024 02:25
738d02f
to
f3470bc
Compare
ekzhu
reviewed
Nov 13, 2024
python/packages/autogen-ext/src/autogen_ext/task/_source_match_termination.py
Outdated
Show resolved
Hide resolved
ekzhu
approved these changes
Nov 19, 2024
ekzhu
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this into autogen-agentchat, there is no external dependency.
moved to autogen-agentchat, pls check again |
ekzhu
approved these changes
Nov 20, 2024
python/packages/autogen-agentchat/tests/test_termination_condition.py
Outdated
Show resolved
Hide resolved
# Conflicts: # python/packages/autogen-agentchat/src/autogen_agentchat/task/__init__.py # python/packages/autogen-agentchat/src/autogen_agentchat/task/_terminations.py # python/packages/autogen-agentchat/tests/test_termination_condition.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Introduces the
AgentNameTermination
class, which is a termination condition for conversations based on last agent nameRelated issue number
Checks