Adding Terminal Velocity Check for CameraCaptureUI Experimental API #4906
+96
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saharsh979
requested review from
AjitSurana,
godlytalias,
Hemantxk and
akanpatel2206
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
godlytalias
approved these changes
Nov 21, 2024
Hemantxk
reviewed
Nov 22, 2024
| inputs: | ||
| targetType: filePath | ||
| filePath: tools\TerminalVelocity\Generate-TerminalVelocityFeatures.ps1 | ||
| arguments: -Path $(Build.SourcesDirectory)\dev\common\TerminalVelocityFeatures-CameraCaptureUI.xml -Channel $(channel) -Language C++ -Namespace Microsoft.Windows.Media.Capture -Output $(Build.SourcesDirectory)\dev\common\TerminalVelocityFeatures-CameraCaptureUI.h |
There was a problem hiding this comment.
Why the generated '.h' file is being checked-in in the repo if you already have a build task to generate it?
Hemantxk
reviewed
Nov 22, 2024
| @@ -73,6 +74,7 @@ namespace Microsoft.Windows.Media.Capture | |||
| } | |||
|
|
|||
| [contract(CameraCaptureUIContract, 1)] | |||
| [feature(Feature_CameraCaptureUI)] | |||
There was a problem hiding this comment.
We should contain CameraCaptureUIPhotoCaptureSettings and CameraCaptureUIVideoCaptureSettings too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a TerminalVelocity check to control the availability of an experimental feature in the Windows App SDK. The feature is enabled in the Experimental channel, while it remains NOOP'd in the Preview and Stable channels, following the TerminalVelocity guidelines for efficient code stripping.
For more information:
https://github.com/microsoft/WindowsAppSDK/blob/main/docs/Coding-Guidelines/Experimental.md
https://github.com/microsoft/WindowsAppSDK/blob/main/docs/Coding-Guidelines/TerminalVelocity.md