Print unique set of PDBs to a text file #4332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
approved these changes
Apr 17, 2024
DrusTheAxe
reviewed
Apr 27, 2024
| { | ||
| Write-Host $value | ||
| } | ||
| New-Item "$(ob_outputDirectory)\pdbs.txt" -Force |
DrusTheAxe
approved these changes
Apr 27, 2024
| $pdbSet = @{} | ||
| $inputPath = "$(Build.ArtifactStagingDirectory)\symbols" | ||
| Get-ChildItem *.pdb -Path $inputPath -Recurse | foreach-object { | ||
| $pdbSet[$_.Name] = $true |
There was a problem hiding this comment.
You're using hashset as a dynamically growable collection? Since you don't care about the value $null would be slightly prefereable to $true
| Write-Host $value | ||
| } | ||
| New-Item "$(ob_outputDirectory)\pdbs.txt" -Force | ||
| $pdbSet.Keys | Out-File "$(ob_outputDirectory)\pdbs.txt" |
There was a problem hiding this comment.
You can replace lines 164-165 with the simpler
$pdbSet.Keys | Set-Content -Path "$(ob_outputDirectory)\pdbs.txt" -Force
You can also control encoding if need be (see other Set-Content uses across the repo for examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.