-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
48525090 Delegate DynamicDependencies to OS API when available #4136
base: main
Are you sure you want to change the base?
Conversation
…uture reference. Rename IsWindows11_23H1OrGreater() to ...24H2... as that's what it's probing. Added IsWindows11_23H2OrGreater()
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…thus APIs like ApiInformation would fail as they require the .winmd at runtime)
…ator, tweaked to work with our test (fake) packages instead of the (real) WinAppSDK MSIX packages
/azp run |
Pull request contains merge conflicts. |
Dependent on completing #4140 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
b0ac1ac
to
9f6f3df
Compare
{ | ||
"Tests": [ | ||
{ | ||
"Description": "UndockedRegFreeWinRT (URFW) tests (arm64 not currently enabled)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not arm64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ummm, copy pasta? But with mushrooms and basil! :P
DIR /S/B *.testdef
test\AppLifecycle\AppLifecycle.testdef
"Architectures": ["x64", "arm64"],
Why no x86?
test\DynamicDependency\Powershell\DynamicDependency_Powershell.testdef
"Architectures": ["x64", "arm64"],
Why no x86?
test\DynamicDependency\Test_Win32\DynamicDependency_API_Win32.testdef
"Architectures": ["x64", "arm64"],
Why no x86?
test\DynamicDependency\Test_WinRT\DynamicDependency_API_WinRT.testdef
"Architectures": ["x64", "arm64"],
Why no x86?
test\PackageManager\API\Test.testdef
"Architectures": ["x86", "x64"],
Why no arm64?
test\PushNotificationTests\PushNotificationTests.testdef
"Architectures": ["x64"],
"Status": "Disabled"
Why no x86 or arm64?
And why disabled?
I'll take care of DynamicDependency + PackageManager (and URFW). You got the rest?
P.S. Additional testing and maybe a fix needed before this is ready for checkin |
hoping it gets worked on. |
https://task.ms/48525090
This changes to only use Detours when needed. Today that's <=22H2 (SV2), or to be pedantic Detours is needed on...
We also use Detours for some Package Graph support required by polyfill Dynamic Dependencies.
Some test environments encountered errors due disabling Detours hooks for DynDep but enabling them for URFW. Keep it consistent to avoid inconsistent behavior.
Summary: