Disallow type and interface declarations in statements with blockless bodies #60183

Andarist · 2024-10-10T10:22:44Z

… bodies

jakebailey · 2024-10-10T14:21:20Z

typescript-bot · 2024-10-10T14:21:23Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-10-10T14:43:08Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-10-10T14:44:51Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60183/merge:

Everything looks good!

typescript-bot · 2024-10-10T15:03:36Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,403k (± 0.75%)}	_{193,450k (± 0.79%)}	_~	_192,712k	_196,540k	_{p=0.471 n=6}
_{Parse Time}	_{1.31s (± 0.62%)}	_{1.31s (± 0.39%)}	_~	_1.31s	_1.32s	_{p=0.929 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.75s (± 0.45%)}	_{9.73s (± 0.26%)}	_~	_9.69s	_9.76s	_{p=1.000 n=6}
_{Emit Time}	_{2.73s (± 0.46%)}	_{2.72s (± 1.34%)}	_~	_2.66s	_2.76s	_{p=0.686 n=6}
_{Total Time}	_{14.51s (± 0.29%)}	_{14.48s (± 0.19%)}	_~	_14.43s	_14.51s	_{p=0.196 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,886	_947,886	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,606k (± 0.00%)}	_{1,224,614k (± 0.00%)}	_~	_1,224,560k	_1,224,669k	_{p=0.574 n=6}
_{Parse Time}	_{6.62s (± 0.25%)}	_{6.61s (± 0.85%)}	_~	_6.56s	_6.72s	_{p=0.145 n=6}
_{Bind Time}	_{1.88s (± 0.27%)}	_{1.88s (± 0.58%)}	_~	_1.86s	_1.89s	_{p=0.784 n=6}
_{Check Time}	_{31.82s (± 0.28%)}	_{31.82s (± 0.28%)}	_~	_31.69s	_31.92s	_{p=0.688 n=6}
_{Emit Time}	_{15.20s (± 0.46%)}	_{15.13s (± 0.25%)}	_~	_15.07s	_15.16s	_{p=0.053 n=6}
_{Total Time}	_{55.52s (± 0.24%)}	_{55.45s (± 0.16%)}	_~	_55.34s	_55.58s	_{p=0.298 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,697	_2,529,697	_~	_~	_~	_{p=1.000 n=6}
_Types	_916,163	_916,163	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,340,983k (± 0.00%)}	_{2,340,948k (± 0.00%)}	_~	_2,340,874k	_2,341,020k	_{p=0.575 n=6}
_{Parse Time}	_{9.41s (± 0.27%)}	_{9.38s (± 0.23%)}	_~	_9.35s	_9.41s	_{p=0.053 n=6}
_{Bind Time}	_{2.17s (± 0.35%)}	_{2.17s (± 0.38%)}	_~	_2.15s	_2.17s	_{p=1.000 n=6}
_{Check Time}	_{76.17s (± 0.36%)}	_{75.63s (± 0.35%)}	_{-0.54s (- 0.72%)}	_75.39s	_76.06s	_{p=0.013 n=6}
_{Emit Time}	_{0.28s (± 1.86%)}	_{0.28s (± 2.70%)}	_~	_0.27s	_0.29s	_{p=0.784 n=6}
_{Total Time}	_{88.04s (± 0.34%)}	_{87.45s (± 0.29%)}	_{-0.58s (- 0.66%)}	_87.20s	_87.89s	_{p=0.013 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,266	_266,266	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,026,020k (± 9.72%)}	_{3,146,316k (± 0.02%)}	_~	_3,145,448k	_3,147,140k	_{p=0.378 n=6}
_{Parse Time}	_{6.57s (± 1.41%)}	_{6.61s (± 0.54%)}	_~	_6.56s	_6.66s	_{p=0.470 n=6}
_{Bind Time}	_{2.34s (± 0.94%)}	_{2.33s (± 1.15%)}	_~	_2.31s	_2.38s	_{p=0.468 n=6}
_{Check Time}	_{43.13s (± 0.46%)}	_{43.02s (± 0.43%)}	_~	_42.75s	_43.23s	_{p=0.471 n=6}
_{Emit Time}	_{3.55s (± 1.16%)}	_{3.51s (± 2.50%)}	_~	_3.35s	_3.58s	_{p=0.471 n=6}
_{Total Time}	_{55.61s (± 0.49%)}	_{55.47s (± 0.36%)}	_~	_55.19s	_55.68s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,109	_1,258,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,266	_266,266	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,496,144k (± 0.02%)}	_{2,496,217k (± 0.02%)}	_~	_2,495,528k	_2,497,237k	_{p=0.810 n=6}
_{Parse Time}	_{5.36s (± 0.37%)}	_{5.36s (± 0.87%)}	_~	_5.28s	_5.41s	_{p=0.470 n=6}
_{Bind Time}	_{1.74s (± 0.43%)}	_{1.73s (± 0.47%)}	_~	_1.72s	_1.74s	_{p=0.120 n=6}
_{Check Time}	_{35.87s (± 0.39%)}	_{35.84s (± 0.38%)}	_~	_35.67s	_36.07s	_{p=0.810 n=6}
_{Emit Time}	_{3.05s (± 1.65%)}	_{3.00s (± 1.22%)}	_~	_2.95s	_3.04s	_{p=0.229 n=6}
_{Total Time}	_{46.01s (± 0.32%)}	_{45.94s (± 0.36%)}	_~	_45.80s	_46.25s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,786	_261,786	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,508	_106,508	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{438,730k (± 0.01%)}	_{438,807k (± 0.01%)}	_{+77k (+ 0.02%)}	_438,778k	_438,857k	_{p=0.045 n=6}
_{Parse Time}	_{4.39s (± 0.87%)}	_{4.41s (± 0.98%)}	_~	_4.33s	_4.46s	_{p=0.518 n=6}
_{Bind Time}	_{1.63s (± 0.51%)}	_{1.63s (± 1.25%)}	_~	_1.61s	_1.66s	_{p=0.681 n=6}
_{Check Time}	_{23.40s (± 0.48%)}	_{23.42s (± 0.37%)}	_~	_23.31s	_23.53s	_{p=0.748 n=6}
_{Emit Time}	_{1.92s (± 1.36%)}	_{1.93s (± 0.39%)}	_~	_1.92s	_1.94s	_{p=0.319 n=6}
_{Total Time}	_{31.33s (± 0.50%)}	_{31.39s (± 0.43%)}	_~	_31.24s	_31.60s	_{p=0.521 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,919	_225,919	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,071k (± 0.02%)}	_{371,089k (± 0.01%)}	_~	_371,037k	_371,158k	_{p=0.575 n=6}
_{Parse Time}	_{2.88s (± 1.15%)}	_{2.90s (± 1.02%)}	_~	_2.86s	_2.94s	_{p=0.461 n=6}
_{Bind Time}	_{1.58s (± 1.94%)}	_{1.58s (± 0.65%)}	_~	_1.57s	_1.60s	_{p=0.513 n=6}
_{Check Time}	_{16.32s (± 0.34%)}	_{16.34s (± 0.42%)}	_~	_16.22s	_16.41s	_{p=0.423 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.78s (± 0.20%)}	_{20.82s (± 0.33%)}	_~	_20.72s	_20.92s	_{p=0.257 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,113,894	_3,113,894	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,073,363	_1,073,363	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,207,305k (± 0.01%)}	_{3,207,372k (± 0.00%)}	_~	_3,207,097k	_3,207,536k	_{p=0.810 n=6}
_{Parse Time}	_{14.05s (± 0.31%)}	_{14.06s (± 0.62%)}	_~	_13.92s	_14.18s	_{p=0.872 n=6}
_{Bind Time}	_{4.47s (± 2.41%)}	_{4.44s (± 0.37%)}	_~	_4.43s	_4.47s	_{p=0.677 n=6}
_{Check Time}	_{85.56s (± 1.69%)}	_{85.50s (± 1.49%)}	_~	_84.71s	_88.07s	_{p=0.810 n=6}
_{Emit Time}	_{24.13s (± 8.58%)}	_{24.09s (± 9.30%)}	_~	_22.58s	_27.14s	_{p=0.376 n=6}
_{Total Time}	_{128.21s (± 2.46%)}	_{128.10s (± 2.41%)}	_~	_125.84s	_133.41s	_{p=0.521 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_285,191	_285,191	_~	_~	_~	_{p=1.000 n=6}
_Types	_115,771	_115,771	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{435,348k (± 0.02%)}	_{435,194k (± 0.02%)}	_{-154k (- 0.04%)}	_435,006k	_435,306k	_{p=0.045 n=6}
_{Parse Time}	_{4.05s (± 1.39%)}	_{4.06s (± 1.23%)}	_~	_3.99s	_4.13s	_{p=0.936 n=6}
_{Bind Time}	_{1.73s (± 1.21%)}	_{1.73s (± 0.87%)}	_~	_1.72s	_1.76s	_{p=0.805 n=6}
_{Check Time}	_{18.33s (± 0.55%)}	_{18.51s (± 1.85%)}	_~	_18.25s	_19.17s	_{p=0.471 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.11s (± 0.42%)}	_{24.30s (± 1.27%)}	_~	_24.06s	_24.89s	_{p=0.149 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,222	_540,222	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,145	_181,145	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,875k (± 0.02%)}	_{483,879k (± 0.01%)}	_~	_483,781k	_483,957k	_{p=0.810 n=6}
_{Parse Time}	_{4.17s (± 0.68%)}	_{4.16s (± 0.38%)}	_~	_4.14s	_4.18s	_{p=0.413 n=6}
_{Bind Time}	_{1.47s (± 0.86%)}	_{1.47s (± 0.57%)}	_~	_1.45s	_1.47s	_{p=0.356 n=6}
_{Check Time}	_{23.67s (± 0.31%)}	_{23.66s (± 0.40%)}	_~	_23.53s	_23.78s	_{p=1.000 n=6}
_{Emit Time}	_{0.01s (±167.16%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.527 n=6}
_{Total Time}	_{29.31s (± 0.30%)}	_{29.28s (± 0.30%)}	_~	_29.18s	_29.41s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-10-10T16:04:00Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60183/merge:

Everything looks good!

jakebailey

This seems right to me?

Disallow type and interface declarations in statements with blockless…

763f526

… bodies

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Oct 10, 2024

jakebailey approved these changes Oct 10, 2024

View reviewed changes

jakebailey requested review from rbuckton and RyanCavanaugh October 10, 2024 19:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disallow type and interface declarations in statements with blockless bodies #60183

Disallow type and interface declarations in statements with blockless bodies #60183

Andarist commented Oct 10, 2024

jakebailey commented Oct 10, 2024

typescript-bot commented Oct 10, 2024 •

edited

Loading

typescript-bot commented Oct 10, 2024

typescript-bot commented Oct 10, 2024

typescript-bot commented Oct 10, 2024

tsc

typescript-bot commented Oct 10, 2024

jakebailey left a comment

Disallow type and interface declarations in statements with blockless bodies #60183

Are you sure you want to change the base?

Disallow type and interface declarations in statements with blockless bodies #60183

Conversation

Andarist commented Oct 10, 2024

jakebailey commented Oct 10, 2024

typescript-bot commented Oct 10, 2024 • edited Loading

typescript-bot commented Oct 10, 2024

typescript-bot commented Oct 10, 2024

typescript-bot commented Oct 10, 2024

tsc

typescript-bot commented Oct 10, 2024

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented Oct 10, 2024 •

edited

Loading