-
Notifications
You must be signed in to change notification settings - Fork 4
Update function params and helpers #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbgms
reviewed
Mar 7, 2025
Contributor
sbgms
previously approved these changes
Mar 7, 2025
Contributor
sbgms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
sbgms
approved these changes
Mar 13, 2025
Contributor
sbgms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes:
This pull request includes several changes to the
src/modules/SdnDiag.NetworkController.psm1andsrc/modules/SdnDiag.Server.psm1files to enhance functionality and improve error handling. The key changes include adding a new parameter to convert output to JSON, modifying parameter attributes, and improving error handling in various functions.Enhancements to functionality:
src/modules/SdnDiag.NetworkController.psm1: Added a newConvertToJsonparameter to theGet-SdnResourcefunction to allow conversion of output to JSON format. [1] [2] [3]Modifications to parameter attributes:
src/modules/SdnDiag.NetworkController.psm1: Changed theNcUriandResourceRefparameters to be mandatory in theGet-SdnResourcefunction.Improvements to error handling:
src/modules/SdnDiag.Server.psm1: Updated multiple functions (Get-VfpPortGroup,Get-VfpPortLayer,Get-VfpPortRule,Get-VfpPortState,Get-VfpVMSwitchPort,Get-SdnOvsdbPhysicalPort) to improve error handling by throwing exceptions with detailed messages when errors occur. [1] [2] [3] [4] [5] [6] [7] [8]Parameter name standardization:
src/modules/SdnDiag.Server.psm1: Standardized the parameter name fromPortIdtoPortNameacross multiple functions to maintain consistency. [1] [2] [3] [4] [5] [6]Change in function behavior:
src/modules/SdnDiag.NetworkController.psm1: Modified theGet-SdnResourcefunction to handle multiple returned objects by updating the$resultvariable instead of returning it directly.Change type
Checklist: