Skip to content

Conversation

@arudell
Copy link
Member

@arudell arudell commented Mar 6, 2025

Description

Summary of changes:
This pull request includes several changes to the src/modules/SdnDiag.NetworkController.psm1 and src/modules/SdnDiag.Server.psm1 files to enhance functionality and improve error handling. The key changes include adding a new parameter to convert output to JSON, modifying parameter attributes, and improving error handling in various functions.

Enhancements to functionality:

Modifications to parameter attributes:

Improvements to error handling:

  • src/modules/SdnDiag.Server.psm1: Updated multiple functions (Get-VfpPortGroup, Get-VfpPortLayer, Get-VfpPortRule, Get-VfpPortState, Get-VfpVMSwitchPort, Get-SdnOvsdbPhysicalPort) to improve error handling by throwing exceptions with detailed messages when errors occur. [1] [2] [3] [4] [5] [6] [7] [8]

Parameter name standardization:

Change in function behavior:

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

@sbgms
Copy link
Contributor

sbgms commented Mar 7, 2025

    Get-SdnVMNetworkAdapterPortProfile -AllVMs

-All ?


Refers to: src/modules/SdnDiag.Server.psm1:2547 in 15ab29c. [](commit_id = 15ab29c, deletion_comment = False)

sbgms
sbgms previously approved these changes Mar 7, 2025
Copy link
Contributor

@sbgms sbgms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@arudell arudell marked this pull request as ready for review March 13, 2025 15:52
@arudell arudell requested a review from a team as a code owner March 13, 2025 15:52
Copy link
Contributor

@sbgms sbgms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@arudell arudell added this pull request to the merge queue Mar 14, 2025
Merged via the queue into main with commit a6da4b6 Mar 14, 2025
4 of 5 checks passed
@arudell arudell deleted the update-function-params-and-helpers branch March 14, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants