Improve data collection performance and output

[arudell]

Description

This pull request includes significant updates to the SdnDiagnostics module, focusing on enhancing role management, improving data collection, and refining configuration handling. The key changes are grouped below by their themes:

Role Management Enhancements:

• Added a new Role property to the $Global:SdnDiagnostics.Config object to define the current roles for the node. (src/SdnDiagnostics.psm1)
• Updated the Get-SdnConfigState function to support multiple roles and set the default role from the global configuration. (src/SdnDiagnostics.psm1)

Data Collection Improvements:

• Introduced the ComputerName property to the data collection object in Start-SdnDataCollection for better tracking of nodes involved in data collection. (src/SdnDiagnostics.psm1)
• Refined the data collection process to handle node limits and ensure proper role-based data collection. (src/SdnDiagnostics.psm1)
• Simplified the cleanup and data collection logic, removing redundant variables and streamlining the process. (src/SdnDiagnostics.psm1) [1] [2]

Configuration Handling:

• Replaced the method to determine the environment mode and role, using Get-EnvironmentMode and Get-EnvironmentRole instead of registry-based methods. (src/SdnDiagnostics.psm1)
• Updated the Get-SdnConfigState function to make the Role parameter optional and default to the global configuration. (src/SdnDiagnostics.psm1)

Miscellaneous Updates:

• Added new cmdlets to the module manifest for enhanced diagnostic capabilities. (src/SdnDiagnostics.psd1)
• Removed unused and redundant code blocks to improve code readability and maintainability. (src/SdnDiagnostics.psm1) [1] [2]

These changes collectively enhance the functionality and maintainability of the SdnDiagnostics module by improving role management, streamlining data collection, and refining configuration handling.

Change type

• Bug fix (non-breaking change)
• Code style update (formatting, local variables)
• New Feature (non-breaking change that adds new functionality without impacting existing)
• Breaking change (fix or feature that may cause functionality impact)
• Other

Checklist:

• My code follows the style and contribution guidelines of this project.
• I have tested and validated my code changes.

[sbgms]

        }

Why are we doing this ? Why not out-null ?

---

Refers to: src/SdnDiagnostics.psm1:333 in f096334. [](commit_id = f096334, deletion_comment = False)

[sbgms]

function Get-CommonConfigState {

fyi, almost everything here is already collected in netview. so to simplify, you could always collect netview and drop this in future perhaps. Nothing for now though.

---

Refers to: src/modules/SdnDiag.Common.psm1:485 in f096334. [](commit_id = f096334, deletion_comment = False)

[sbgms]

[sbgms]

[sbgms]

Looks good!