Skip to content

Conversation

@arudell
Copy link
Member

@arudell arudell commented Feb 20, 2025

Description

Summary of changes:
This pull request primarily introduces new functionality related to Virtual Filtering Platform (VFP) enabled virtual switches in the SDN diagnostics module. The most significant changes include the addition of a new cmdlet, updates to existing cmdlets, and enhancements to the diagnostics configuration.

New Functionality:

  • Added Get-SdnVMSwitch cmdlet to retrieve virtual switches from the hypervisor with an option to filter by VFP enabled switches.
  • Introduced Test-SdnVfpEnabledVMSwitch cmdlet to check that only one VFP enabled virtual switch is configured on the system.

Enhancements to Existing Cmdlets:

  • Updated Get-SdnNetAdapterEncapOverheadConfig to support filtering by switch name or ID and to use the new Get-SdnVMSwitch cmdlet for retrieving VFP enabled switches. [1] [2]

Configuration and Diagnostics Updates:

  • Added new entries for Get-SdnVMSwitch and Test-SdnVfpEnabledVMSwitch in the src/SdnDiagnostics.psd1 file. [1] [2]
  • Included Test-SdnVfpEnabledVMSwitch in the diagnostics configuration file with description and impact details.
  • Integrated Test-SdnVfpEnabledVMSwitch into the Debug-SdnServer function to be part of the diagnostic tests.

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

@arudell arudell linked an issue Feb 20, 2025 that may be closed by this pull request
@arudell arudell added the enhancement New feature or request label Feb 20, 2025
@arudell arudell self-assigned this Feb 20, 2025
@arudell arudell changed the title [Debug] Add health test to check for multiple switches that have VFP extension enabled Add health test to check for multiple switches that have VFP extension enabled Feb 20, 2025
@arudell arudell marked this pull request as ready for review February 20, 2025 18:59
@arudell arudell requested a review from a team as a code owner February 20, 2025 18:59
@arudell arudell enabled auto-merge February 20, 2025 18:59
@arudell arudell added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 76095ef Feb 25, 2025
4 of 5 checks passed
@arudell arudell deleted the create-health-test-for-multiple-vfp-switches branch February 25, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Debug] Add test to check if multiple vmswitches have VFP enabled

3 participants