Merge pull request #51 from JarLob/enum

HAA0102 false positive fixed
microsoft · Nov 10, 2018 · 8911358 · 8911358
2 parents db50c67 + c8ef476
commit 8911358
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/ClrHeapAllocationsAnalyzer.Test/CallSiteImplicitAllocationAnalyzerTests.cs b/ClrHeapAllocationsAnalyzer.Test/CallSiteImplicitAllocationAnalyzerTests.cs
@@ -80,6 +80,21 @@ public void CallSiteImplicitAllocation_DoNotReportNonOverriddenMethodCallForStat
             var analyser = new CallSiteImplicitAllocationAnalyzer();
             var info = ProcessCode(analyser, snippet, ImmutableArray.Create(SyntaxKind.InvocationExpression));
 
+            Assert.AreEqual(0, info.Allocations.Count);
+          }
+
+        [TestMethod]
+        public void CallSiteImplicitAllocation_DoNotReportNonOverriddenMethodCallForNonVirtualCalls() {
+            var snippet = @"
+using System.IO;
+
+FileAttributes attr = FileAttributes.System;
+attr.HasFlag (FileAttributes.Directory);
+";
+
+            var analyser = new CallSiteImplicitAllocationAnalyzer();
+            var info = ProcessCode(analyser, snippet, ImmutableArray.Create(SyntaxKind.InvocationExpression));
+
             Assert.AreEqual(0, info.Allocations.Count);
           }
     }

diff --git a/ClrHeapAllocationsAnalyzer/CallSiteImplicitAllocationAnalyzer.cs b/ClrHeapAllocationsAnalyzer/CallSiteImplicitAllocationAnalyzer.cs
@@ -34,7 +34,7 @@ protected override void AnalyzeNode(SyntaxNodeAnalysisContext context)
 
             if (semanticModel.GetSymbolInfo(invocationExpression, cancellationToken).Symbol is IMethodSymbol methodInfo)
             {
-                if (!methodInfo.IsStatic)
+                if (methodInfo.IsOverride)
                 {
                     CheckNonOverridenMethodOnStruct(methodInfo, reportDiagnostic, invocationExpression, filePath);
                 }