Skip to content

Compiler fixes for ProcDump #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jcfaracco wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Compiler fixes for ProcDump #297

jcfaracco wants to merge 2 commits into from

Conversation

@jcfaracco
Copy link
Contributor

@jcfaracco jcfaracco commented Oct 14, 2025

This PR basically fixes two compilation errors in ProcDump 3.5.0. The first one is an unused variable inside the function stress_cpu, and the other error is just a malformed variable initialization.

The first report is:

gmake[2]: Leaving directory '/root/rpmbuild/BUILD/procdump-3.5.0-build/ProcDump-for-Linux-3.5.0/redhat-linux-build'
/root/rpmbuild/BUILD/procdump-3.5.0-build/ProcDump-for-Linux-3.5.0/tests/integration/ProcDumpTestApplication.c: In function ‘stress_cpu’:
/root/rpmbuild/BUILD/procdump-3.5.0-build/ProcDump-for-Linux-3.5.0/tests/integration/ProcDumpTestApplication.c:85:21: error: variable ‘work_time’ set but not used [-Werror=unused-but-set-variable]
   85 |     struct timespec work_time, sleep_time;
      |                     ^~~~~~~~~

And the second one is:

/root/rpmbuild/BUILD/procdump-3.5.0-build/ProcDump-for-Linux-3.5.0/src/Monitor.cpp:1608:51: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
 1608 |     struct TerminalState originalTerminalState = {0};
      |                                                   ^
      |                                                   {}

@jcfaracco
tests: Remove unused variable work_time from stress_cpu function
8a9f47e 
This `work_time` variable is not being used in the `stress_cpu`
function. It can be removed to avoid issues with the compiler.

Signed-off-by: Julio Faracco <[email protected]>
@jcfaracco
Initialize TerminalState structure properly
30d8ca7 
The structure TerminalState is not a pointer. So, it should be properly
initialized with a double brackets. This commit just fixes this warning
to avoid compilation failures.

Signed-off-by: Julio Faracco <[email protected]>
@jcfaracco
Copy link
Contributor Author

jcfaracco commented Oct 14, 2025

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jcfaracco