Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspaces] Fix case: monitor not present at launch #37005

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

donlaci
Copy link
Collaborator

@donlaci donlaci commented Jan 22, 2025

Summary of the Pull Request

If the monitor is not detected at launch, which is stored in the config, set coordinates to the main window work area

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

If the monitor is not detected at launch, we make the window minimised. The PR adds also, that the window coordinates are set to main window's work area. It is needed, because the coordinates can be outside of visible area and after restoring the window, it won't be visible. The fix sets the coordinates too.

Validation Steps Performed

@jaimecbernardo
Copy link
Collaborator

Thanks for opening this PR. CI is failing because of some XAML style errors that got into main. Please merge latest main in to fix that. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants