[New+]Don't override New actions from Explorer on Windows 10 #36467
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgaarden, FYI. 😄 |
jaimecbernardo
changed the title
stefansjfw
approved these changes
Dec 20, 2024
jaimecbernardo
commented
Dec 20, 2024
src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp
Show resolved
Hide resolved
…ontext_menu_win10.cpp
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp
Fixed
Show fixed
Hide fixed
src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
jaimecbernardo
commented
Dec 20, 2024
src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp
Outdated
Show resolved
Hide resolved
…ontext_menu_win10.cpp
src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
davidegiacometti
approved these changes
Dec 20, 2024
|
Sweet! Thank you @jaimecbernardo for this fixing this! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
New+ is currently trying to respond to verbs that don't correspond to the submenu item call in InvokeCommand. Checking old documentation for InvokeCommand, we can see that we're missing a check in there.
https://learn.microsoft.com/en-us/previous-versions//bb776881(v=vs.85)?redirectedfrom=MSDN#invokecommand-method
PR Checklist
Detailed Description of the Pull Request / Additional comments
Just adds the check we require to make sure we're not responding to "string"-based verbs, according to the documentation.
Validation Steps Performed
Verified that on Windows 10 with this build it's possible to now call New Folder from the WIndows Explorer Ribbon and also through the Ctrl+Shift+N shortcut. Now a new folder gets created instead of the old one. Also tried to create a New text file from the ribbon and it worked. Also tried New+ features to make sure they were still working.