-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Run] Improve error MessageBox #34564
Conversation
@davidegiacometti |
I'll check. Thanks for pointing out this. |
This comment has been minimized.
This comment has been minimized.
I have verified and one plugin error dialog was addressed in #25095. |
9ee52f5
to
67be391
Compare
@davidegiacometti
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM . ❤️ This is a big quality of life improvement.
Co-authored-by: Heiko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the contribution!
Summary of the Pull Request
This is not a fix to the error, but an improvement to MessageBox error title since it's not clear to the user that the it's related to PT Run.
This was partially addressed by #25095, but not for all the errors.
PR Checklist
Detailed Description of the Pull Request / Additional comments
MessageBox.Show(...)
errors that could be triggered on startup, detecting which need to explicit call out "PT Run"IPublicAPI.ShowMsg(...)
dialogs need "PT Run" in title since they are usually showed as a response to a user interaction (example click on a result or action).Validation Steps Performed