Allow multiple relationships in ConnectorType #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CompileTimeTypeWrapperRecordValue.TryGetField
|
✅ No public API change. |
LucGenetier
commented
Nov 20, 2024
LucGenetier
commented
Nov 20, 2024
src/libraries/Microsoft.PowerFx.Connectors/Tabular/Capabilities/ComplexColumnCapabilities.cs
Show resolved
Hide resolved
LucGenetier
commented
Nov 20, 2024
src/libraries/Microsoft.PowerFx.Core/Public/Values/CompileTimeTypeWrapperRecordValue.cs
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Connectors/OpenApiExtensions.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Connectors/Public/ConnectorType.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Connectors/Public/ConnectorType.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.PowerFx.Connectors/Tabular/Capabilities/ColumnCapabilitiesDefinition.cs
Show resolved
Hide resolved
|
Public API changes: |
MikeStall
reviewed
Nov 21, 2024
| @@ -17,6 +17,8 @@ | |||
| using Microsoft.PowerFx.Core.Utils; | |||
| using Microsoft.PowerFx.Types; | |||
| using static Microsoft.PowerFx.Connectors.Constants; | |||
|
|
|||
| #pragma warning disable SA1000 // The keyword 'new' should be followeed by a space | |||
There was a problem hiding this comment.
Do we just want to remove this at the editorconfig level?
MikeStall
reviewed
Nov 21, 2024
|
|
||
| namespace Microsoft.PowerFx.Connectors | ||
| { | ||
| public class ConnectorRelationship |
There was a problem hiding this comment.
for now, yes
as discussed this is a temporary thing
I'll add [Obsolete] to it
MikeStall
reviewed
Nov 21, 2024
| this.DisplayName == other.DisplayName && | ||
| this.Description == other.Description && | ||
| this.IsRequired == other.IsRequired && | ||
| Enumerable.SequenceEqual((IList<ConnectorType>)this.Fields ?? Array.Empty<ConnectorType>(), (IList<ConnectorType>)other.Fields ?? Array.Empty<ConnectorType>()) && |
LucGenetier
commented
Nov 21, 2024
| using Microsoft.PowerFx.Types; | ||
|
|
||
| namespace Microsoft.PowerFx.Connectors | ||
| { | ||
| public static class CdpExtensions | ||
| { | ||
| public static bool TryGetFieldExternalTableName(this RecordType recordType, string fieldName, out string tableName, out string foreignKey) | ||
| public static bool TryGetFieldRelationships(this RecordType recordType, string fieldName, out IEnumerable<ConnectorRelationship> relationships) |
MikeStall
reviewed
Nov 21, 2024
| @@ -72,5 +73,32 @@ public static ColumnCapabilities ParseColumnCapabilities(IDictionary<string, IOp | |||
| IsChoice = isChoice | |||
| }); | |||
| } | |||
|
|
|||
| public bool Equals(ColumnCapabilities other) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple relationships in ConnectorType
Fix CompileTimeTypeWrapperRecordValue.TryGetField
Add Equals to ConnectorType
This update doesn't update CdpRecordType yet
DV and NL repos are not impacted by these changes