Conversation
|
Did you test the inference of the output model? I tested https://huggingface.co/google/gemma-3-270m but it failed with onnxruntime-genai when inferencing (this will be fixed soon), but I'm not sure if you got an error as well for Gemma3-4b with qnn. |
We have intelligible output from the text portion of the model within our KPIs but we have not successfully prepared the vision portion of the model or combined the two models together in a pipeline of OGA. Do you have details on what specific portion of the model you had issues with? |
I encountered a bug in model builder when testing gemma-3-270m, but it has now been fixed. Interestingly the 4B model works without issues, maybe there are some difference between their configs. If it is tested, I'm fine. Thanks. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This fixes the issue of text model repeating words in the output.
qti-kromero
left a comment
There was a problem hiding this comment.
apparently I have to make a comment
|
@jambayk @xiaoyu-work wondering if this could get reviewed when you have a chance |
|
Hi @qti-kromero , is this changed required for recipe microsoft/olive-recipes#125? |
correct, although we may need to retest these changes since we haven't revisited them for awhile due to higher priority work |
Thanks for confirming this! Let me know if they are ready for review and I will review both PRs together. |
|
Closing for now since the PR has become stale |
Describe your changes
Checklist before requesting a review
lintrunner -a