Skip to content

Commit

Permalink
Merge pull request #5305 from mpoulson/mpoulson/5213
Browse files Browse the repository at this point in the history
Add check if NewUnifiedGroupWritebackDefault can be set for Azure Gov
  • Loading branch information
NikCharlebois authored Nov 5, 2024
2 parents d59a7c2 + f8edf5f commit 2ab3248
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@
* Exponential performance improvements by reducing complexity and roundtrips.
* Changed the logic that appends GUID in the resource name when primary key is not found during an
export. We will only append a GUID if the IsSingleInstance property is not found on the resource.
* Add check in AADGroupSettings for NewUnifiedGroupWritebackDefault not existing in Government by default
FIXES [#5213](https://github.com/microsoft/Microsoft365DSC/issues/5213)
* DEPENDENCIES
* Updated Microsoft.Graph to version 2.24.0.
* Updated Microsoft.PowerApps.Administration.PowerShell to version 2.0.199.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ function Get-TargetResource
GuestUsageGuidelinesUrl = $valueGuestUsageGuidelinesUrl.Value
AllowToAddGuests = [Boolean]::Parse($valueAllowToAddGuests.Value)
UsageGuidelinesUrl = $valueUsageGuidelinesUrl.Value
NewUnifiedGroupWritebackDefault = [Boolean]::Parse($valueNewUnifiedGroupWritebackDefault.Value)
Ensure = 'Present'
ApplicationId = $ApplicationId
TenantId = $TenantId
Expand All @@ -148,7 +147,11 @@ function Get-TargetResource
Managedidentity = $ManagedIdentity.IsPresent
AccessTokens = $AccessTokens
}

if (-not [System.String]::IsNullOrEmpty($valueNewUnifiedGroupWritebackDefault.Value))
{
$result.Add('NewUnifiedGroupWritebackDefault', [Boolean]::Parse($valueNewUnifiedGroupWritebackDefault.Value))
}

if (-not [System.String]::IsNullOrEmpty($AllowedGroupName))
{
$result.Add('GroupCreationAllowedGroupName', $AllowedGroupName)
Expand Down

0 comments on commit 2ab3248

Please sign in to comment.