Theme Docker Container Selector Dialog #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the Docker Container Selector Dialog in Visual Studio to be themed. The following changes were done: - Updates VS packages since some of the newer theming was in newer packages. - Newer packages had new attributes that needed to be handled with MakePIAPortableTool. - Converted ListBox to ListView for ContainerPickerDialog and modified associated automation peers
WardenGnaw
requested review from
mpeyrotc,
chuckries,
asundheim,
gregg-miskelly and
CarlosGuerraVz
WardenGnaw
commented
Dec 19, 2023
asundheim
approved these changes
Dec 19, 2023
|
I'm not sure this dialog needs a Maximize button, but if you do add it check how it looks when maximized, as other times I've used a WindowChrome for adding a tittle bar it causes the dialog to get slightly bigger than the screen when maximized, looking something like this: |
CarlosGuerraVz
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Docker Container Selector Dialog in Visual Studio to be themed. The following changes were done:
Old:
New (Dark Theme):
New (Dark Theme) with Error:
New (Blue Contrast):
