Skip to content

Commit

Permalink
Merge pull request #1485 from microsoft/dev/waan/complianceFixes
Browse files Browse the repository at this point in the history
Update Nuget Packages for Compliance
  • Loading branch information
WardenGnaw authored Dec 20, 2024
1 parent 074837e commit 4aef1f4
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 22 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/Build-And-Test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ jobs:
path: ${{ github.workspace }}/bin/DebugAdapterProtocolTests/Debug/CppTests/results.trx

osx_build:
runs-on: macos-12
runs-on: macos-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -168,8 +168,10 @@ jobs:
- run: |
${{ github.workspace }}/eng/Scripts/CI-Build.sh
- run: |
${{ github.workspace }}/eng/Scripts/CI-Test.sh
# Disabling lldb-mi tests since DownloadLldbMI.sh will obtain
# an x64 version instead of an arm64 and test will fail.
# - run: |
# ${{ github.workspace }}/eng/Scripts/CI-Test.sh

- name: 'Upload Test Results'
uses: actions/upload-artifact@v4
Expand Down
10 changes: 0 additions & 10 deletions build/Analyzers.targets
Original file line number Diff line number Diff line change
@@ -1,18 +1,8 @@
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<!-- Disable Legacy FxCop -->
<RunCodeAnalysis>false</RunCodeAnalysis>
<EnableNETAnalyzers>true</EnableNETAnalyzers>

<!-- Point to ruleset -->
<CodeAnalysisRuleSet>..\IDECodeAnalysis.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.VersionCheckAnalyzer" Version="3.3.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeQuality.Analyzers" Version="3.3.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.NetCore.Analyzers" Version="3.3.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.NetFramework.Analyzers" Version="3.3.0" PrivateAssets="all" />
</ItemGroup>
</Project>
18 changes: 9 additions & 9 deletions build/package_versions.settings.targets
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<Microsoft_VisualStudio_Debugger_Interop_Portable_Version>1.0.1</Microsoft_VisualStudio_Debugger_Interop_Portable_Version>
<Microsoft_VisualStudio_Interop_Version>17.11.40262</Microsoft_VisualStudio_Interop_Version>
<Microsoft_VisualStudio_Interop_Version>17.12.40391</Microsoft_VisualStudio_Interop_Version>
<Newtonsoft_Json_Version>13.0.3</Newtonsoft_Json_Version>
<Microsoft_VisualStudio_Shared_VSCodeDebugProtocol_Version>17.2.60629.1</Microsoft_VisualStudio_Shared_VSCodeDebugProtocol_Version>

<!-- Test Packages -->
<Microsoft_NET_Test_Sdk_Version>16.7.1</Microsoft_NET_Test_Sdk_Version>
<xunit_Version>2.4.1</xunit_Version>
<xunit_runner_visualstudio_Version>2.4.3</xunit_runner_visualstudio_Version>
<xunit_Version>2.9.2</xunit_Version>
<xunit_runner_visualstudio_Version>3.0.0</xunit_runner_visualstudio_Version>
<coverlet_collector_Version>1.3.0</coverlet_collector_Version>
<MSTest_TestFramework_Version>2.1.2</MSTest_TestFramework_Version>

Expand All @@ -25,19 +25,19 @@
<Microsoft_VisualStudio_Debugger_Interop_15_0_Version>17.5.33428.366</Microsoft_VisualStudio_Debugger_Interop_15_0_Version>
<Microsoft_VisualStudio_Debugger_Interop_16_0_Version>17.5.33428.366</Microsoft_VisualStudio_Debugger_Interop_16_0_Version>
<Microsoft_VisualStudio_Debugger_InteropA_Version>17.5.33428.366</Microsoft_VisualStudio_Debugger_InteropA_Version>
<Microsoft_VisualStudio_Shell_15_0_Version>17.11.40262</Microsoft_VisualStudio_Shell_15_0_Version>
<Microsoft_VisualStudio_Shell_Framework_Version>17.11.40262</Microsoft_VisualStudio_Shell_Framework_Version>
<Microsoft_VisualStudio_Threading_Version>17.11.20</Microsoft_VisualStudio_Threading_Version>
<Microsoft_VisualStudio_Utilities_Version>17.11.40262</Microsoft_VisualStudio_Utilities_Version>
<Microsoft_VisualStudio_Shell_15_0_Version>17.12.40392</Microsoft_VisualStudio_Shell_15_0_Version>
<Microsoft_VisualStudio_Shell_Framework_Version>17.12.40391</Microsoft_VisualStudio_Shell_Framework_Version>
<Microsoft_VisualStudio_Threading_Version>17.12.19</Microsoft_VisualStudio_Threading_Version>
<Microsoft_VisualStudio_Utilities_Version>17.12.40391</Microsoft_VisualStudio_Utilities_Version>
<Microsoft_VisualStudio_Shell_Interop_15_0_DesignTime_Version>15.0.26932</Microsoft_VisualStudio_Shell_Interop_15_0_DesignTime_Version>
<Microsoft_VisualStudio_Workspace_Version>15.0.392</Microsoft_VisualStudio_Workspace_Version>
<Microsoft_VisualStudio_Workspace_VSIntegration_Version>15.0.392</Microsoft_VisualStudio_Workspace_VSIntegration_Version>
<Microsoft_VisualStudio_TextManager_Interop_Version>17.11.40262</Microsoft_VisualStudio_TextManager_Interop_Version>
<Microsoft_VisualStudio_TextManager_Interop_Version>17.12.40391</Microsoft_VisualStudio_TextManager_Interop_Version>
<Microsoft_VSSDK_BuildTools_Version>17.3.2093</Microsoft_VSSDK_BuildTools_Version>
<System_Runtime_Loader_Version>4.3.0</System_Runtime_Loader_Version>

<!-- For Component Governance -->
<Microsoft_IO_Redist_Version>6.0.1</Microsoft_IO_Redist_Version>
<System_Text_Json_Version>8.0.4</System_Text_Json_Version>
<System_Text_Json_Version>8.0.5</System_Text_Json_Version>
</PropertyGroup>
</Project>

0 comments on commit 4aef1f4

Please sign in to comment.