[python-package] fix test_numeric_split_direction to test all parameter combinations #7131
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er combinations The test was skipping the [use_missing=True, zero_as_missing=True] combination instead of properly testing it. When both flags are True, zeros and NaN are both treated as missing and reach the same leaf. The assertion now correctly checks for same leaf (when zero_as_missing=True) vs different leaves (when False).
wagner-austin
requested review from
StrikerRUS,
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
jameslamb
approved these changes
Jan 18, 2026
Collaborator
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Oh interesting, thanks so much for looking into this!!
The proposed changes and code comments look clear and correct to me. this is a nice improvement to the testing coverage.
I see that pytest.skip() was added in #5119 but I don't recall why and don't see conversation related to it. @jmoralez could you double-check this PR if you have time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
test_numeric_split_directiontest was skipping the[use_missing=True, zero_as_missing=True]parameter combination instead of properly testing it.When both flags are True:
use_missing=True: NaN values are treated as missingzero_as_missing=True: Zero values are also treated as missingThe original assertion
assert expected_leaf_zero != expected_leaf_nanwould fail for this case, which is why it was skipped. The fix properly tests this case by checking for the same leaf whenzero_as_missing=True.Test Plan
BEFORE (master):
test_numeric_split_direction[True-True]: SKIPPEDtest_numeric_split_direction[True-False]: PASSEDtest_numeric_split_direction[False-True]: PASSEDtest_numeric_split_direction[False-False]: PASSEDAFTER (this PR):