[python-package] cast numpy integer to float in plot_importance ax.text call #7130
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt call The y-coordinate passed to matplotlib's ax.text() was a numpy signedinteger from np.arange(), but matplotlib's type stubs expect a Python float. This cast follows the existing pattern in engine.py where float() is used to convert numpy values.
wagner-austin
requested review from
StrikerRUS,
borchero,
guolinke,
jameslamb,
jmoralez and
shiyu1994
as code owners
jameslamb
approved these changes
Jan 18, 2026
Collaborator
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Looks good to me, and confirmed this results in 0 remaining mypy errors in plotting.py: https://github.com/microsoft/LightGBM/actions/runs/21103515583/job/60691173605#step:3:891
Thanks!
Collaborator
|
I've changed the description to:
"fixes" should only be used if the issue could be closed after this PR is merged, which isn't true here (there are still 6 more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy Error (before fix)
Related Issue
Contributes to #3867
Description
The y-coordinate passed to matplotlib's
ax.text()inplot_importance()was a numpysignedintegerfrom iterating overnp.arange(), but matplotlib's type stubs expect a Pythonfloat.This cast follows the existing pattern in
engine.pywherefloat()is used to convert numpy values (e.g.,float(np.mean(v))at line 624).Test Plan
pre-commit run mypy --files python-package/lightgbm/plotting.py- passedpytest tests/python_package_test/test_plotting.py- 13 passed, 1 skipped (pre-existing skip unrelated to this change)