build(client): upgrade typescript-eslint to v8.50 #26187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b0901dc.
Remove all eslint-suppressions.json files from the repository. These files were added to suppress ESLint violations during the typescript-eslint upgrade and are no longer needed.
Add eslint-disable comments for prefer-nullish-coalescing, prefer-optional-chain, no-unsafe-enum-comparison, strict-boolean-expressions, no-base-to-string, and await-thenable rules where auto-fix is unsafe. These violations were previously suppressed by eslint-suppressions.json files which have been removed. Using inline disables instead of auto-fix because the auto-fixers can cause subtle logic bugs when converting || to ?? or && chains to ?. chains for falsy (but valid) values.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades typescript-eslint from v8.18 to v8.50 and @eslint/js from v8.57 to v9.39. The upgrade includes a critical parser configuration fix and adds inline ESLint suppressions where auto-fixing would change code behavior.
Changes:
- Upgrades core ESLint dependencies to latest compatible versions
- Fixes parser options conflict by explicitly setting
project: nullwhen usingprojectService - Adds inline suppressions for prefer-nullish-coalescing, prefer-optional-chain, and other rules where auto-fix could change behavior with falsy values
Reviewed changes
Copilot reviewed 88 out of 90 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates dependency versions for typescript-eslint (v8.50), @eslint/js (v9.39), eslint-plugin-jsdoc (v61.5) |
| common/build/eslint-config-fluid/package.json | Updates package dependency specifiers to match lock file |
| common/build/eslint-config-fluid/flat.mts | Adds project: null parser option to prevent conflict with projectService |
| common/build/eslint-config-fluid/printed-configs/*.json | Auto-generated config changes from new ESLint rule versions |
| packages//src/**/.ts | Adds inline suppressions with justifications for cases where auto-fix would be unsafe |
Files not reviewed (2)
- common/build/eslint-config-fluid/pnpm-lock.yaml: Language not supported
- pnpm-lock.yaml: Language not supported
tylerbutler
commented
Jan 12, 2026
| throw new Error("Invalid Snapshot."); | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/strict-boolean-expressions, @typescript-eslint/prefer-nullish-coalescing -- intentional behavior |
Member
Author
There was a problem hiding this comment.
What does intentional behavior mean? Here and elsehwere.
tylerbutler
commented
Jan 12, 2026
| * Licensed under the MIT License. | ||
| */ | ||
|
|
||
| /* eslint-disable @typescript-eslint/prefer-nullish-coalescing, @typescript-eslint/prefer-optional-chain */ |
Member
Author
There was a problem hiding this comment.
Add TODO comments for all file-wide suppressions.
tylerbutler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades typescript-eslint from v8.18 to v8.50 and @eslint/js from v8.57 to v9.39.
Key changes:
project: nullin parser options to prevent conflict withprojectServicein newer typescript-eslint versions||to??or&&chains to?.would change behavior for falsy-but-valid values (0, false, empty string)