ci: Fix git tagging during releases #24284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
tylerbutler
commented
Apr 8, 2025
tools/pipelines/templates/include-publish-npm-package-deployment.yml
Outdated
Show resolved
Hide resolved
alexvy86
previously approved these changes
Apr 8, 2025
Contributor
alexvy86
left a comment
alexvy86
left a comment
There was a problem hiding this comment.
Looks good; a couple of small things.
tools/pipelines/templates/include-publish-npm-package-deployment.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Villarreal <[email protected]>
alexvy86
approved these changes
Apr 8, 2025
alexvy86
added a commit
that referenced
this pull request
Apr 8, 2025
## Description Follow up to #24284 to fix a syntax issue.
alexvy86
added a commit
that referenced
this pull request
Apr 16, 2025
## Description Removes some redundant Component Governance checks: - In the build pipeline for the client release group we split building the repository into one job and running tests in separate jobs. Some of the latter were running the CG tasks even though the build one already did, because they check out the repo again. They now won't. - We [recently introduced a new job](#24284) to create a tag in the repo after publishing a public release, as a fix for a previous change. That job is also running the CG checks unnecessarily since the build already happened at that point, and we only check out the repo to be able to create a tag in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent pipeline refactoring broke the git tagging of releases. This change updates the pipeline to check out the repo in a separate job and tag the commit. This keeps it separate from the deployment job.