build(build-tools): Enable unused variable linting #24272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
tylerbutler
commented
Apr 7, 2025
build-tools/packages/build-infrastructure/src/test/packageJsonUtils.test.ts
Outdated
Show resolved
Hide resolved
alexvy86
previously approved these changes
Apr 7, 2025
| /** | ||
| * A transformer function that does nothing. | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
Contributor
There was a problem hiding this comment.
Curious why do this here instead of the underscore prefix.
Member
Author
There was a problem hiding this comment.
I can't figure out why, but the lint rule gets tripped even when disabled in the config. I ended up just removing the placeholder args completely.
alexvy86
reviewed
Apr 7, 2025
| import detectIndent from "detect-indent"; | ||
| // Imports are written this way for CJS/ESM compat | ||
| import fsePkg from "fs-extra"; | ||
| // eslint-disable-next-line import/no-named-as-default-member -- Imports are written this way for CJS/ESM compat |
Contributor
There was a problem hiding this comment.
Are these just warnings and we're being good citizens and documenting them? Can't be that enabling the other rule somehow made this one start complaining, right?
Member
Author
There was a problem hiding this comment.
Yeah, they're just warnings, but I noticed that there was a comment already so I converted it to a disable with the explanation.
jason-ha
reviewed
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unused variable eslint rule was not enabled in build-tools and the tsconfig noUnusedLocals option was disabled (by design), so unused variables were not caught before merge.
This change updates the lint config in build-tools to catch these issues in lint and makes the necessary changes to the source.