Add GroupSharedLimit attribute support for Mesh, Amp and Node shaders#8140
Merged
JoeCitizen merged 14 commits intomicrosoft:mainfrom Feb 13, 2026
Merged
Add GroupSharedLimit attribute support for Mesh, Amp and Node shaders#8140JoeCitizen merged 14 commits intomicrosoft:mainfrom
JoeCitizen merged 14 commits intomicrosoft:mainfrom
Conversation
Collaborator
JoeCitizen
commented
Feb 4, 2026
JoeCitizen
commented
- Adds support for the GroupSharedLimit feature for Mesh, Amplification and Node shaders.
- Tests for each of those shader types
damyanp
reviewed
Feb 9, 2026
tools/clang/test/HLSLFileCheckLit/hlsl/entry/attributes/GroupSharedLimitAmplification.hlsl
Outdated
Show resolved
Hide resolved
tex3d
reviewed
Feb 9, 2026
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
With minor suggested changes from earlier resolved comment, tests could easily check some more interesting edge cases that I've pointed out. As it stands, I'm not sure the update truly addressed the resolved comment from earlier.
tools/clang/test/HLSLFileCheckLit/hlsl/entry/attributes/GroupSharedLimitAmplification.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/HLSLFileCheckLit/hlsl/entry/attributes/GroupSharedLimitMesh.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/HLSLFileCheckLit/hlsl/entry/attributes/GroupSharedLimitNode.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/HLSLFileCheckLit/hlsl/entry/attributes/GroupSharedLimitNodeError.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/HLSLFileCheckLit/hlsl/entry/attributes/GroupSharedLimit.hlsl
Outdated
Show resolved
Hide resolved
tex3d
requested changes
Feb 11, 2026
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Diagnostics need overhaul, but I've provided a suggested implementation.
tex3d
approved these changes
Feb 12, 2026
damyanp
reviewed
Feb 12, 2026
V-FEXrt
reviewed
Feb 12, 2026
Collaborator
V-FEXrt
left a comment
V-FEXrt
left a comment
There was a problem hiding this comment.
Generally LGTM but the more I sat with it, the more I think we need to do something about the -1 magic. Happy to leave it up to you on exactly what to do but it should be named in some manner
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
Co-authored-by: Damyan Pepper <damyanp@microsoft.com>
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
damyanp
approved these changes
Feb 13, 2026
V-FEXrt
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.