Update IDxcVersionInfo header docs to be more accurate #8066
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tex3d
approved these changes
Jan 15, 2026
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
LGTM.
For clarity, should we add a comment to the GetVersionInfo() method on IDxcPdbUtils[2] interfaces to clarify that this method gets the version info for the compiler that produced the currently loaded PDB or DXIL? That method's purpose doesn't really seem clear otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous docs were....misleading at best. This change makes them more accurate.