[NFC][SM 6.9 Release] Missed a version string. #8062
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsepkow
changed the title
hekota
previously approved these changes
Jan 15, 2026
damyanp
previously approved these changes
Jan 15, 2026
alsepkow
dismissed stale reviews from damyanp and hekota
The base branch was changed.
damyanp
approved these changes
Jan 15, 2026
alsepkow
changed the title
tex3d
approved these changes
Jan 15, 2026
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
If we guarantee this is overridden in all build paths, maybe we should consider replacing the string with something that indicates that in the future.
IIRC we had several different build paths for versioning, but I don't recall if this file would ever be used as-is. If it had, it would have been for a release branch build, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed updating a version string in version.inc. gen_version.py overwrites this anyways, so it's not a big issue. But best to keep this clean.